Chore: add build tags to e2etest #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
requested changes
Jul 26, 2022
There was a problem hiding this comment.
Thanks for this change @vuong177
There are also e2e tests that are located in this file. We should add build tags there too.
Also, I think that the following might not function correctly now due to the missing tags:
make test-e2emake test-e2e-skip-upgrade
We should make sure that e2e-specific makefile steps keep working as before.
Lastly, this debug configuration configuration needs to be updated so that people can configure their local environment easily. Would you mind updating it please?
github-actions
bot
added
C:docs
|
I updated README and changed |
p0mvn
reviewed
Aug 2, 2022
czarcas7ic
approved these changes
Aug 8, 2022
p0mvn
approved these changes
Aug 10, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 10, 2022
* add build tags to e2etest * update makefile * update VS Code Debug Configuration in e2e test README * init_test e2e * e2e package in makefile (cherry picked from commit 5e2bb89) # Conflicts: # Makefile # tests/e2e/README.md
p0mvn
pushed a commit
that referenced
this pull request
Aug 11, 2022
* Chore: add build tags to e2etest (#2231) * add build tags to e2etest * update makefile * update VS Code Debug Configuration in e2e test README * init_test e2e * e2e package in makefile (cherry picked from commit 5e2bb89) # Conflicts: # Makefile # tests/e2e/README.md * fix conflict * Update Makefile Co-authored-by: vuong <56973102+vuong177@users.noreply.github.com> Co-authored-by: vuong <nguyenvuong1122000@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2174
What is the purpose of the change
Add build tags to make e2e tests not run on
go test ./...Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)nox/<module>/spec/) / Osmosis docs repo / not documented)not applicable