refactor: clean up keeper interfaces #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:app-wiring
ValarDragon
reviewed
Aug 13, 2022
x/txfees/types/expected_keepers.go
Outdated
Comment on lines
50
to
55
| // TxFeesKeeper defines the expected transaction fee keeper | ||
| type TxFeesKeeper interface { | ||
| ConvertToBaseToken(ctx sdk.Context, inputFee sdk.Coin) (sdk.Coin, error) | ||
| GetBaseDenom(ctx sdk.Context) (denom string, err error) | ||
| GetFeeToken(ctx sdk.Context, denom string) (FeeToken, error) | ||
| } |
There was a problem hiding this comment.
Lets keep this one, so other modules can import it, rather than having to redefine it locally
(I think types packages defining succinct, exported interfaces that other modules can directly reference is good when applicable)
Looks like we don't do this already, but we should have a type check for txfees keeper implementing this interface
ValarDragon
approved these changes
Aug 13, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 13, 2022
* refactor: clean up keeper interfaces * rename community pool keeper * changelog * restore TxFeesKeeper and type check (cherry picked from commit 1313b63) # Conflicts: # CHANGELOG.md # app/keepers/keepers.go # x/incentives/keeper/gauge.go # x/incentives/keeper/keeper.go # x/txfees/types/expected_keepers.go
p0mvn
added a commit
that referenced
this pull request
Aug 13, 2022
p0mvn
added a commit
that referenced
this pull request
Aug 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
DistrKeepertoCommunityPoolKeeperTesting and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no