feat: add multiple docker images #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niccoloraspa
commented
Aug 18, 2022
| @@ -13,8 +13,7 @@ RUN set -eux; apk add --no-cache ca-certificates build-base; apk add git linux-h | |||
|
|
|||
| # Download go dependencies | |||
| WORKDIR /osmosis | |||
| COPY go.mod go.mod | |||
| COPY go.sum go.sum | |||
| COPY go.* . | |||
ValarDragon
approved these changes
Aug 18, 2022
p0mvn
approved these changes
Aug 18, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Change default image && copy all go deps in 1 layer * Extend workflow to push multiple docker images (cherry picked from commit 4b5eccf) # Conflicts: # Dockerfile
ValarDragon
pushed a commit
that referenced
this pull request
Aug 19, 2022
* feat: add multiple docker images (#2440) * Change default image && copy all go deps in 1 layer * Extend workflow to push multiple docker images (cherry picked from commit 4b5eccf) # Conflicts: # Dockerfile * Fix conflicts Co-authored-by: Niccolo Raspa <6024049+niccoloraspa@users.noreply.github.com> Co-authored-by: Niccolo Raspa <nraspa@live.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues: #2427
What is the purpose of the change
This PR adds additional flavors to the osmosis Docker image.
Now you can run the
osmosisdbinary from:All images have
amd64andarm64support.I have also changed the default docker image from
static:nonroottostatic.Why all of this
Distroless container images are IMHO the best way to run a golang binary. However,
nonrootimages have created permission problems in the past. To simplify, I'm proposing to usestaticdistroless images as our default but still offer the possibility to run anonrootDocker image via the-nonrootsuffix.Distroless images contain, by design, only the binary and no shell.
This limitation led to the proliferation of various spurious Docker images created ad-hoc to solve specific problems.
Introducing
alpineimages could help reduce the number of Docker images we have: #1679, and it can be helpful in dev/testing scenarios.Brief Changelog
gcr.io/distroless/staticosmosisddocker images with the same binary.Testing and Verifying
I have tested the workflow from my fork: https://github.com/niccoloraspa/osmosis/actions/runs/2875632534.
Triggered the workflow by creating a fake tag
v12.12.22that pushed the following images in theosmolabs/osmosis-testregistry.docker run osmolabs/osmosis-test:12.12.22 docker run osmolabs/osmosis-test:12.12.22-alpine docker run osmolabs/osmosis-test:12.12.22-distroless docker run osmolabs/osmosis-test:12.12.22-nonroot # Also osmolabs/osmosis-test:12, osmolabs/osmosis-test:12.12, osmolabs/osmosis-test:latestDocumentation and Release Note
Unreleasedsection inCHANGELOG.md? no