-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade wasmd to v0.28.0 #2714
Conversation
I've investigated the simulator failure, and it seems to be happening during fee validation in osmosis/x/txfees/keeper/feetokens.go Line 112 in 1d9c6e3
Essentially, wasmd generates a tx with a random fee: I think the solution should be to modify wasmd side and hardcode the denom to be "stake" |
Seems that we only allow fees in "uosmo" in our simulator too: osmosis/simulation/simtypes/legacy.go Lines 38 to 39 in 1d9c6e3
So I'm going to go ahead and make the change wasmd side and retag |
Recommend v0.29.0 in fact. Also, I just vendored x/wasm and x/globalfees into eve, and I gotta say it feels about right, there won't be as much upstream dependency chaos that way. I'd be happy to hack on any of that for osmo. |
@@ -355,7 +355,7 @@ func RandomExitSwapShareAmountIn(k keeper.Keeper, sim *simtypes.SimCtx, ctx sdk. | |||
PoolId: pool_id, | |||
TokenOutDenom: tokenOut.Denom, | |||
ShareInAmount: gammShares.Amount.Quo(sdk.NewInt(2)), | |||
TokenOutMinAmount: tokenOut.Amount, | |||
TokenOutMinAmount: tokenOut.Amount.Quo(sdk.NewInt(2)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The simulator was failing because of this. I think the calculations above are making it flaky so this change is made to unblock v12. Once the TODO above is addressed, this should be as well
v0.29.0 is still an RC. Also, we really want to get v12 out, and this is one of the last missing pieces. Since regular wasmd tag requires additional changes to be compatible with Osmosis, I think we will go with v0.28 for the sake of delivering v12. However, happy to upgrade to v0.29 as soon as stable release is out.
Do you mean added it directly into the repository? How are you planning to integrate improvements from upstream? |
* chore: upgrade wasmd to v0.28.0 * changelog * fix simulator * update dependency * simulator time hack * update simulator * remove curTime * update tag * update comments * updates * update wasmd dep (cherry picked from commit b1c92ae)
* chore: upgrade wasmd to v0.28.0 (#2714) * chore: upgrade wasmd to v0.28.0 * changelog * fix simulator * update dependency * simulator time hack * update simulator * remove curTime * update tag * update comments * updates * update wasmd dep (cherry picked from commit b1c92ae) * updates Co-authored-by: Roman <roman@osmosis.team> Co-authored-by: Roman <ackhtariev@gmail.com>
Part of #2566
What is the purpose of the change
Upgrade wasmd to v0.28.0
Branch: https://github.com/osmosis-labs/wasmd/tree/v0.28.0x-osmo-v12
Tag: https://github.com/osmosis-labs/wasmd/releases/tag/v0.28.0-osmo-v12.1
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? no