Implement BigDec binary search in osmoutils
#2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
reviewed
Sep 20, 2022
p0mvn
approved these changes
Sep 20, 2022
Co-authored-by: Roman <roman@osmosis.team>
This was referenced Sep 21, 2022
ValarDragon
reviewed
Sep 22, 2022
ValarDragon
reviewed
Sep 22, 2022
ValarDragon
reviewed
Sep 22, 2022
ValarDragon
approved these changes
Sep 22, 2022
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
AlpinYukseloglu
added a commit
that referenced
this pull request
Sep 22, 2022
This reverts commit b6995ab.
mergify bot
pushed a commit
that referenced
this pull request
Sep 22, 2022
…rch (#2816) Progress towards: #2794 ## What is the purpose of the change This PR replaces our stableswap two-asset CFMM solver to use the `BigDec` binary search implementation in #2802 Note: most of the diff is tests merged from #2697 and the core binary search logic from #2802, both of which had to be merged into this branch ## Brief Changelog - Replace binary search solver logic with our `BigDec` binary search implementation ## Testing and Verifying - All two-asset CFMM test cases were set up to test this implementation in `amm_test.go` ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? (no) - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? (no) - How is the feature or change documented? (not documented)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards: #2794 and #2702
What is the purpose of the change
This PR implements a
BigDecbinary search function for our general osmoutils package.Brief Changelog
BinarySearchBigDecto osmoutilsCompareBigDecto osmoutilst.Runetc.)Testing and Verifying
This change added tests for both new functions in
osmoutils/binary_search_test.goDocumentation and Release Note
Unreleasedsection inCHANGELOG.md? (no)