stableswap: Add multi-asset support threading, via scaled reserve API change #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/gamm
ValarDragon
added
V:state/compatible/no_backport
github-actions
bot
added
the
C:x/gamm
AlpinYukseloglu
approved these changes
Sep 29, 2022
|
|
||
| result[i] = amt.ToDec().QuoInt64Mut(int64(scalingFactor)) | ||
| // scaledPoolReserves returns scaled amount of pool liquidity for usage in AMM equations | ||
| func (p Pool) scaledPoolReserves() ([]sdk.DecCoin, error) { |
There was a problem hiding this comment.
I love this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
All of the stableswap functions assumed 2 asset pools still for getting the scaled reserves. This PR fixes this, by making methods to get all scaled reserves at once, but reordering the first and second field as needed.
We may want to change the result type from DecCoin to BigDec in a second pass though
Testing and Verifying
This change is already covered by existing tests,
TestScaledSortedPoolReserves.Added tests for multi-asset pools