Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stableswap: swap, scale rounding & swapfee alignment w/ spec #2912

Merged
merged 4 commits into from
Oct 1, 2022
Merged

Stableswap: swap, scale rounding & swapfee alignment w/ spec #2912

merged 4 commits into from
Oct 1, 2022

Conversation

ValarDragon
Copy link
Member

What is the purpose of the change

  • Adds spec for swap methods
  • Aligns swap code's scale rounding calls, and swap fee to be in line with spec

Testing and Verifying

This code remains untested

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes

@ValarDragon ValarDragon requested review from AlpinYukseloglu and a team September 30, 2022 21:13
@ValarDragon ValarDragon added the V:state/breaking State machine breaking PR label Sep 30, 2022
@github-actions github-actions bot added C:docs Improvements or additions to documentation C:x/gamm Changes, features and bugs related to the gamm module. labels Sep 30, 2022
@AlpinYukseloglu AlpinYukseloglu mentioned this pull request Oct 1, 2022
Merged
AlpinYukseloglu
AlpinYukseloglu approved these changes Oct 1, 2022
View reviewed changes
Copy link
Contributor

@AlpinYukseloglu AlpinYukseloglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added tests + a few other major changes as a PR to this branch (to not block this one and because it ended up leading to some other broader changes)

@ValarDragon ValarDragon merged commit f4c37ab into main Oct 1, 2022
@ValarDragon ValarDragon deleted the dev/stableswap_specs branch October 1, 2022 07:13
@AlpinYukseloglu AlpinYukseloglu mentioned this pull request Oct 1, 2022
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlpinYukseloglu AlpinYukseloglu AlpinYukseloglu approved these changes

Assignees
No one assigned
Labels
C:docs Improvements or additions to documentation C:x/gamm Changes, features and bugs related to the gamm module. V:state/breaking State machine breaking PR
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValarDragon @AlpinYukseloglu