Add TWAP CLI #3214
Merged
Add TWAP CLI #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
added
A:backport/v12.x
github-actions
bot
added
C:app-wiring
mattverse
approved these changes
Nov 2, 2022
| } | ||
|
|
||
| // GetCmdAssetMultiplier returns multiplier of an asset by denom. | ||
| func GetQueryTwapCommand() *cobra.Command { |
There was a problem hiding this comment.
nit: don't know if its worth overhead, but would love to have some test cases on this since this includes lot of internal parsing. We could also make it a separate issue for this if u agree with the needs of testing for this
There was a problem hiding this comment.
Happy if someone else wants to write tests for this, I think of it as pretty low priority.
I'd much rather allocate those mental cycles to getting most CLI code killed / better testing structures. (I believe SDK has progress on better CLI testing structure)
Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
## What is the purpose of the change Add CLI query support for TWAP. I've eye ball-tested the values for correctness against imperator API. Ideally we add this logic to our querygen, or use proto-reflect from SDK to automate CLI boilerplate going for. ## Testing and Verifying Manually tested ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? yes - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? yes - How is the feature or change documented? CLI help (cherry picked from commit e3e8e27) # Conflicts: # CHANGELOG.md
ValarDragon
added a commit
that referenced
this pull request
Nov 2, 2022
* Add TWAP CLI (#3214) ## What is the purpose of the change Add CLI query support for TWAP. I've eye ball-tested the values for correctness against imperator API. Ideally we add this logic to our querygen, or use proto-reflect from SDK to automate CLI boilerplate going for. ## Testing and Verifying Manually tested ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? yes - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? yes - How is the feature or change documented? CLI help (cherry picked from commit e3e8e27) # Conflicts: # CHANGELOG.md * Fix changelog conflict Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Dev Ojha <dojha@berkeley.edu>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add CLI query support for TWAP. I've eye ball-tested the values for correctness against imperator API. Ideally we add this logic to our querygen, or use proto-reflect from SDK to automate CLI boilerplate going for.
Testing and Verifying
Manually tested
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes