Add CalcJoinPoolShares and CalcExitPoolCoinsFromShares pool queries to Stargate whitelist #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
reviewed
Nov 14, 2022
p0mvn
reviewed
Nov 14, 2022
Co-authored-by: Roman <roman@osmosis.team>
github-actions
bot
removed
the
C:x/gamm
|
@p0mvn I changed the workflow files to match what is in |
p0mvn
reviewed
Nov 14, 2022
|
@p0mvn Is there anything else I should do to get this merged in? |
p0mvn
approved these changes
Nov 15, 2022
czarcas7ic
approved these changes
Nov 15, 2022
Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Nov 15, 2022
…o Stargate whitelist (#3217) * TotalDelegationByValidatorForAsset query + tests * TotalDelegationByValidatorForAsset + tests * TotalDelegationByValidatorForAsset + test * names changed * save * TotalDelegationByValidatorForDenom query * TotalDelegationByValidatorForDenom * JoinSwapExactAmountIn query * ExitSwapShareAmountIn query * JoinSwapExactAmountIn, ExitSwapShareAmountIn queries * JoinSwapExactAmountIn, ExitSwapShareAmountIn queries * JoinSwapExactAmountIn, ExitSwapShareAmountIn queries * JoinSwapExactAmountIn, ExitSwapShareAmountIn queries * JoinSwapExactAmountIn, ExitSwapShareAmountIn queries * JoinSwapExactAmountIn, ExitSwapShareAmountIn queries * save * test: finish CalcJoinPoolShares query test * tests for CalcExitPoolCoinsFromShares * tests for CalcExitPoolCoinsFromShares * save * test: add additional exit coin tests * docs rpc TotalDelegationByValidatorForDenom * TotalDelegationByValidatorForDenom clean * TotalDelegationByValidatorForDenom query * TotalDelegationByValidatorForDenom query * TotalDelegationByValidatorForDenom query * query * save * Update x/gamm/keeper/grpc_query.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update x/gamm/keeper/grpc_query.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update x/gamm/keeper/grpc_query.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * queries * docs fix * feat: add two pool shares queries to stargate whitelist * chore: update changelog * feat: generate proto files * chore: generate proto files * autocli copy from cosmos * reset * save * SimJoinPoolNoSwap * docs * JoinPoolNoSwap simulation * more fixes * fix docs and name * fix: change tokens_in type * test: fix TestCalcJoinPoolNoSwapShares test * feat: build query.pb.go file * name version >> * update action v * check variable * action from personal fork * remove tag * chore: remove whitespace Co-authored-by: Roman <roman@osmosis.team> * chore: workflow files * chore: fix docker.yml file * chore: fix required_labels.yml * chore: remove space * Update CHANGELOG.md Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> Co-authored-by: Ruslan Akhtariev <ruslanakhtariev@Ruslans-MacBook-Air.local> Co-authored-by: Ruslan Akhtariev <46343690+RusAkh@users.noreply.github.com> Co-authored-by: Roman <roman@osmosis.team> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> (cherry picked from commit 03ec730)
p0mvn
pushed a commit
that referenced
this pull request
Nov 15, 2022
…o Stargate whitelist (#3217) (#3385) * TotalDelegationByValidatorForAsset query + tests * TotalDelegationByValidatorForAsset + tests * TotalDelegationByValidatorForAsset + test * names changed * save * TotalDelegationByValidatorForDenom query * TotalDelegationByValidatorForDenom * JoinSwapExactAmountIn query * ExitSwapShareAmountIn query * JoinSwapExactAmountIn, ExitSwapShareAmountIn queries * JoinSwapExactAmountIn, ExitSwapShareAmountIn queries * JoinSwapExactAmountIn, ExitSwapShareAmountIn queries * JoinSwapExactAmountIn, ExitSwapShareAmountIn queries * JoinSwapExactAmountIn, ExitSwapShareAmountIn queries * JoinSwapExactAmountIn, ExitSwapShareAmountIn queries * save * test: finish CalcJoinPoolShares query test * tests for CalcExitPoolCoinsFromShares * tests for CalcExitPoolCoinsFromShares * save * test: add additional exit coin tests * docs rpc TotalDelegationByValidatorForDenom * TotalDelegationByValidatorForDenom clean * TotalDelegationByValidatorForDenom query * TotalDelegationByValidatorForDenom query * TotalDelegationByValidatorForDenom query * query * save * Update x/gamm/keeper/grpc_query.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update x/gamm/keeper/grpc_query.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update x/gamm/keeper/grpc_query.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * queries * docs fix * feat: add two pool shares queries to stargate whitelist * chore: update changelog * feat: generate proto files * chore: generate proto files * autocli copy from cosmos * reset * save * SimJoinPoolNoSwap * docs * JoinPoolNoSwap simulation * more fixes * fix docs and name * fix: change tokens_in type * test: fix TestCalcJoinPoolNoSwapShares test * feat: build query.pb.go file * name version >> * update action v * check variable * action from personal fork * remove tag * chore: remove whitespace Co-authored-by: Roman <roman@osmosis.team> * chore: workflow files * chore: fix docker.yml file * chore: fix required_labels.yml * chore: remove space * Update CHANGELOG.md Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> Co-authored-by: Ruslan Akhtariev <ruslanakhtariev@Ruslans-MacBook-Air.local> Co-authored-by: Ruslan Akhtariev <46343690+RusAkh@users.noreply.github.com> Co-authored-by: Roman <roman@osmosis.team> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> (cherry picked from commit 03ec730) Co-authored-by: George <42020095+georgemc98@users.noreply.github.com>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2956 and dependent on PR #2972
What is the purpose of the change
This PR adds the
CalcJoinPoolSharesandCalcExitPoolCoinsFromSharesqueries added in PR #2972 to the whitelisted Stargate queries in the wasmbindings.Brief Changelog
(for example:)
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes