Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stableswap spec for error tolerance mathematics #3292

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Update stableswap spec for error tolerance mathematics #3292

merged 3 commits into from
Nov 8, 2022

Conversation

ValarDragon
Copy link
Member

Subcomponent of #1451

What is the purpose of the change

Note in spec some of the complexity within error tolerance choices in stableswap.

Brief Changelog

Testing and Verifying

This is docs updates, for existing tested behavior

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? spec

@ValarDragon ValarDragon requested review from a team and AlpinYukseloglu November 8, 2022 00:55
@ValarDragon ValarDragon added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Nov 8, 2022
@github-actions github-actions bot added C:docs Improvements or additions to documentation C:x/gamm Changes, features and bugs related to the gamm module. labels Nov 8, 2022
AlpinYukseloglu
AlpinYukseloglu approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@AlpinYukseloglu AlpinYukseloglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, really neat to see this come together so cleanly :)

@AlpinYukseloglu
Copy link
Contributor

If you agree with the lint changes I think we're good to merge this!

@ValarDragon ValarDragon merged commit 4e2b942 into main Nov 8, 2022
@ValarDragon ValarDragon deleted the dev/stableswap_spec branch November 8, 2022 03:31
@AlpinYukseloglu AlpinYukseloglu mentioned this pull request Nov 8, 2022
Closed
34 tasks
@ValarDragon ValarDragon added the A:backport/v13.x backport patches to v13.x branch label Nov 8, 2022
mergify bot pushed a commit that referenced this pull request Nov 8, 2022
@ValarDragon @mergify
Update stableswap spec for error tolerance mathematics (#3292)
464776f 
* Update spec for error tolerance mathematics

* Add proof

* markdown lint

Co-authored-by: alpo <yukseloglua@berkeley.edu>
(cherry picked from commit 4e2b942)
@mergify mergify bot mentioned this pull request Nov 8, 2022
Merged
ValarDragon added a commit that referenced this pull request Nov 8, 2022
@mergify @ValarDragon
Update stableswap spec for error tolerance mathematics (#3292) (#3308)
764e343 
* Update spec for error tolerance mathematics

* Add proof

* markdown lint

Co-authored-by: alpo <yukseloglua@berkeley.edu>
(cherry picked from commit 4e2b942)

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlpinYukseloglu AlpinYukseloglu AlpinYukseloglu approved these changes

Assignees
No one assigned
Labels
A:backport/v13.x backport patches to v13.x branch C:docs Improvements or additions to documentation C:x/gamm Changes, features and bugs related to the gamm module. V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValarDragon @AlpinYukseloglu