Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to IBC v3.4.0 #3313

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Upgrade to IBC v3.4.0 #3313

merged 2 commits into from
Nov 10, 2022

Conversation

ValarDragon
Copy link
Member

What is the purpose of the change

Upgrade to IBC v3.4.0, this should require no migration https://github.com/cosmos/ibc-go/releases/tag/v3.4.0

Adds the metadata field, needed to unblock cross-chain swaps with no multihop.

Brief Changelog

  • Upgrade to IBC v3.4.0

Testing and Verifying

Covered by E2E

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? (not applicable

@ValarDragon ValarDragon requested a review from a team November 9, 2022 07:36
@ValarDragon ValarDragon added V:state/breaking State machine breaking PR A:backport/v13.x backport patches to v13.x branch labels Nov 9, 2022
@czarcas7ic
Copy link
Member

@nicolaslara does this additional metadata field effect the rate limiter at all?

Bringing this up due to the unforeseen effect timestamp had on it

czarcas7ic
czarcas7ic approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing offline, this lgtm

@czarcas7ic czarcas7ic merged commit 18cafcf into main Nov 10, 2022
@czarcas7ic czarcas7ic deleted the dev/upgrade_to_ibc_v34 branch November 10, 2022 00:58
mergify bot pushed a commit that referenced this pull request Nov 10, 2022
@ValarDragon @mergify
Upgrade to IBC v3.4.0 (#3313)
2696ca3 
* Upgrade to IBC v3.4.0

* Changelog update

(cherry picked from commit 18cafcf)
@mergify mergify bot mentioned this pull request Nov 10, 2022
Merged
czarcas7ic pushed a commit that referenced this pull request Nov 10, 2022
@mergify @ValarDragon
Upgrade to IBC v3.4.0 (#3313) (#3316)
bbd4d5b 
* Upgrade to IBC v3.4.0

* Changelog update

(cherry picked from commit 18cafcf)

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
@nicolaslara
Copy link
Contributor

I was wondering the same thing. I'll look intro it, but the easiest solution is just to add it to the packet representation in the contract

@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

Assignees
No one assigned
Labels
A:backport/v13.x backport patches to v13.x branch V:state/breaking State machine breaking PR
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValarDragon @czarcas7ic @nicolaslara