Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 spot price queries #3335

Merged
merged 7 commits into from
Nov 11, 2022
Merged

v2 spot price queries #3335

merged 7 commits into from
Nov 11, 2022

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Nov 10, 2022 •
edited
Loading

What is the purpose of the change

Add v2 queries for spot price, without changing any v1beta1 queries.
Removes v1beta1 for spot price from cosmwasm whitelist. Replaces them with v2 queries. Should be safe as no mainnet contract uses spot price query.

Brief Changelog

Adds v2 queries

Testing and Verifying

(Please pick one of the following options)

This change added tests and can be verified as follows:

  • Adds v2 spot price query tests
  • Adds wasmbinding integration test

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? Not documented, should be

@ValarDragon ValarDragon added V:state/breaking State machine breaking PR A:backport/v13.x backport patches to v13.x branch labels Nov 10, 2022
@github-actions github-actions bot added C:app-wiring Changes to the app folder C:x/gamm Changes, features and bugs related to the gamm module. labels Nov 10, 2022
@github-actions github-actions bot added C:CLI C:x/twap Changes to the twap module labels Nov 11, 2022
@ValarDragon ValarDragon marked this pull request as ready for review November 11, 2022 00:17
@ValarDragon ValarDragon requested a review from a team November 11, 2022 00:17
@ValarDragon ValarDragon merged commit 6c4f423 into main Nov 11, 2022
@ValarDragon ValarDragon deleted the dev/v2_queries branch November 11, 2022 01:42
@mergify mergify bot mentioned this pull request Nov 11, 2022
Merged
mergify bot pushed a commit that referenced this pull request Nov 11, 2022
@ValarDragon @mergify
v2 spot price queries (#3335)
1ccbdae 
* Make v2 queries

* More WIP

* Add twap query v2

* Update twap query in whitelist

* Add changelog

* v2 query test

* Add wasmbinding test

(cherry picked from commit 6c4f423)
ValarDragon added a commit that referenced this pull request Nov 11, 2022
@mergify @ValarDragon
v2 spot price queries (#3335) (#3339)
28eaeb6 
* Make v2 queries

* More WIP

* Add twap query v2

* Update twap query in whitelist

* Add changelog

* v2 query test

* Add wasmbinding test

(cherry picked from commit 6c4f423)

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0mvn p0mvn p0mvn approved these changes

Assignees
No one assigned
Labels
A:backport/v13.x backport patches to v13.x branch C:app-wiring Changes to the app folder C:CLI C:x/gamm Changes, features and bugs related to the gamm module. C:x/twap Changes to the twap module V:state/breaking State machine breaking PR
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValarDragon @p0mvn