Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Delete statesync-rocks.bash #3520

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Conversation

faddat
Copy link
Member

@faddat faddat commented Nov 25, 2022

Closes: #3517

What is the purpose of the change

This file isn't needed anymore.

#3507 adds pebbledb state sync for mainnet and testnet. testnet works well, but mainnet does not.

Brief Changelog

  • delete the special purpose rocksdb state sync file

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no) no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no) no
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented) not applicable

@faddat faddat requested a review from a team November 25, 2022 16:10
@czarcas7ic czarcas7ic added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v13.x backport patches to v13.x branch labels Nov 25, 2022
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@faddat faddat changed the title Delete statesync-rocks.bash chore: Delete statesync-rocks.bash Nov 25, 2022
@ValarDragon ValarDragon merged commit 9b1f11b into main Nov 25, 2022
@ValarDragon ValarDragon deleted the faddat/remove-rocks-state-sync branch November 25, 2022 19:02
mergify bot pushed a commit that referenced this pull request Nov 25, 2022
(cherry picked from commit 9b1f11b)
ValarDragon pushed a commit that referenced this pull request Nov 25, 2022
(cherry picked from commit 9b1f11b)

Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v13.x backport patches to v13.x branch T:build V:state/compatible/backport State machine compatible PR, should be backported
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

State sync is broken in v12.2.1+
3 participants