feat[CL]: add MsgCreateConcentratedPool #3607
Conversation
github-actions
bot
added
C:app-wiring
|
@p0mvn addressed most of your comments with a few followups! |
|
@czarcas7ic thanks, replied to the remaining unresolved discussions |
|
@p0mvn all concerns addressed! |
|
@p0mvn I got rid of the internal model package but for some reason proto check is failing on this as well as the go test. Is this normal? |
|
@czarcas7ic I think there might be an import that is still referencing the old package |
|
@p0mvn Just double checked and there isnt :/ |
|
I think that its a false error. It was passing before, and the changes I made dont effect this.. |
|
Yeah, I reverted back to a point where it was passing and it still fails, so I think its something to do with CI |
| @@ -56,6 +57,14 @@ func (server msgServer) CreateStableswapPool(goCtx context.Context, msg *stables | |||
| return &stableswap.MsgCreateStableswapPoolResponse{PoolID: poolId}, nil | |||
| } | |||
|
|
|||
| func (server msgServer) CreateConcentratedPool(goCtx context.Context, msg *cl.MsgCreateConcentratedPool) (*cl.MsgCreateConcentratedPoolResponse, error) { | |||
There was a problem hiding this comment.
Based on discussions with Dev yesterday, we are going to move the "create pool" message servers to their respective modules. So this would go to CL. Can you try moving it please? It should still call the swaprouter's CreatePool keeper method
Stableswap and GAMM will get moved to gamm but let's do that in another PR.
|
Closing in favor of #3687 |
Closes: #3245
What is the purpose of the change
Implementation of MsgCreateConcentratedPool and required wiring
Brief Changelog
(for example:)