mint: change tests #3662
Closed
mint: change tests #3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dude this is great! @ValarDragon is it okay to merge into your branch? |
|
I think it is okay as we discussed that already 👍. Shall I merge? |
|
I don't know that we can merge this easily unfortunately -- mint wasn't adjusted in the initial PR because mint's differences from everything else are inherited from the SDK. So this is actually mint-CLI breaking |
|
Hrmm, I think we should make a github issue for breaking mint CLI. I want to do this, we just need to get changelog set, release in a minor version and communicate to integrators. Going to close PR, b/c conflicts and rebase needed. I think we can PR the same change as a clean PR, and then get changelog/integrator comm plan figured out, and ship it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x/minttests run usingosmocli