feat(osmomath): Power with decimal exponent #3731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
commented
Dec 17, 2022
osmomath/decimal.go
Outdated
Comment on lines
1034
to
1041
| // PowerMut returns a result of raising the given big dec to | ||
| // a positive decimal power. Panics if the power is negative. | ||
| // Panics if the base is negative. Mutates the receiver. | ||
| // N.B.: support for negative power can be added when needed. | ||
| func (d BigDec) PowerMut(power BigDec) BigDec { | ||
| d.i.Set(d.Power(power).i) | ||
| return d | ||
| } |
There was a problem hiding this comment.
Unsure if there is value in this
p0mvn
added
the
V:state/compatible/no_backport
p0mvn
requested review from
czarcas7ic,
ValarDragon,
nicolaslara and
stackman27
nicolaslara
reviewed
Dec 19, 2022
nicolaslara
reviewed
Dec 19, 2022
nicolaslara
reviewed
Dec 19, 2022
ValarDragon
reviewed
Dec 20, 2022
osmomath/decimal.go
Outdated
Comment on lines
1050
to
1053
| func (d BigDec) PowerMut(power BigDec) BigDec { | ||
| d.i.Set(d.Power(power).i) | ||
| return d | ||
| } |
There was a problem hiding this comment.
err this is backwards. We should write the mutative method here, and then have Power just make a copy then run PowerMut
There was a problem hiding this comment.
Or just delete power mut for now
Unless the idea is to keep this as an API stub, to optimize later?
There was a problem hiding this comment.
I'm happy to delete this for now.
Since we rely on Exp2 function for the underlying implementation, making a mutative PowerMut is not as trivial as making MulMut.
p0mvn
changed the title
|
Addressed comments by removing |
p0mvn
commented
Dec 20, 2022
ValarDragon
reviewed
Dec 20, 2022
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
ValarDragon
approved these changes
Dec 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Implements
PowerandPowerMutwith a decimal exponent. Tests added.Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no