Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved tests out of ibc hooks #3803

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

nicolaslara
Copy link
Contributor

What is the purpose of the change

Moves the ibc hooks tests out of x/ibc-hooks/ and into tests/ibc-hooks/.

This is the first step for making ibc hooks importable by other chains

Brief Changelog

  • Moves the ibc hooks tests out of x/ibc-hooks/ and into tests/ibc-hooks/.

Testing and Verifying

all tests should pass

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Dec 20, 2022
@nicolaslara nicolaslara added the V:state/compatible/backport State machine compatible PR, should be backported label Dec 20, 2022
@ValarDragon ValarDragon added the A:backport/v13.x backport patches to v13.x branch label Dec 20, 2022
@ValarDragon ValarDragon merged commit 2f4aa4e into main Dec 20, 2022
@ValarDragon ValarDragon deleted the nicolas/extract-ibc-hooks-tests branch December 20, 2022 15:25
mergify bot pushed a commit that referenced this pull request Dec 20, 2022
(cherry picked from commit 2f4aa4e)

# Conflicts:
#	tests/ibc-hooks/testutils/Cargo.lock
#	x/ibc-hooks/ibc_middleware_test.go
@ValarDragon ValarDragon added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks and removed V:state/compatible/backport State machine compatible PR, should be backported labels Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v13.x backport patches to v13.x branch C:docs Improvements or additions to documentation V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants