Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeouts always return a success #4179

Merged
merged 5 commits into from
Feb 1, 2023
Merged

Timeouts always return a success #4179

merged 5 commits into from
Feb 1, 2023

Conversation

nicolaslara
Copy link
Contributor

@nicolaslara nicolaslara commented Jan 31, 2023 •
edited
Loading

Closes: #4157

What is the purpose of the change

Allow users to customize whether contract callbacks can fail IBC timeouts

Timeouts always return a success, but emit the error if there is any

Brief Changelog

  • Added configurable timeout failures for contracts
  • Timeputs always return a success, but emit any errors in the contract

Testing and Verifying

All tests should pass

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@nicolaslara nicolaslara added the V:state/compatible/backport State machine compatible PR, should be backported label Jan 31, 2023
@nicolaslara nicolaslara marked this pull request as ready for review February 1, 2023 09:44
@nicolaslara nicolaslara changed the title Timeouts always return a success by default Timeouts always return a success Feb 1, 2023
ValarDragon
ValarDragon approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs:

  • Changelog
  • Gas limit logic
  • State entry written

I think all but changelog can happen later

@ValarDragon
Copy link
Member

Should we make IBC-hooks have its own changelog?

@nicolaslara
Copy link
Contributor Author

Added the following tickets for tracking the related comments:

@nicolaslara nicolaslara merged commit 16f809b into main Feb 1, 2023
@nicolaslara nicolaslara deleted the nicolas/timeout-hooks-controls branch February 1, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

Assignees
No one assigned
Labels
V:state/compatible/backport State machine compatible PR, should be backported
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IBC hooks: Make timeout failures log and return
2 participants
@nicolaslara @ValarDragon