Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min consensus fee arithmetic twap debugging #4341

Closed
wants to merge 41 commits into from
Closed

Min consensus fee arithmetic twap debugging #4341

wants to merge 41 commits into from

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Feb 16, 2023

Closes: #XXX

What is the purpose of the change

ValarDragon and others added 30 commits February 7, 2023 16:56
@ValarDragon
Refactor tests a bit
dfe43ca
@ValarDragon
Add consensus min gas fee
38946b7
@ValarDragon
Fix tests
c676d48
@ValarDragon
Delete more crud
923b45e
@ValarDragon
Cleanup more duplicate test cases
7a82e14
@ValarDragon
flip isCheckTx sign
125d59d
@ValarDragon
One more test needed
13679ce
@ValarDragon
Run invalid fee denom test across both check & deliver
295aebb
@ValarDragon
Remove extra line
a374529
@ValarDragon
Merge branch 'main' into dev/consensus_min_gas_fee
8c7f27d
@ValarDragon
Add hack to get around txfee problem in ibctesting
e42e675
@ValarDragon
Handle genesis
f40b0c7
@ValarDragon
Minor code cleanup
b278a48
@ValarDragon
tryfix simulation
5db078c
@ValarDragon
Fix for legacy simulator
a8b5c4c
@ValarDragon @mattverse
Update x/txfees/keeper/feedecorator_test.go
275cfb8 
Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
@ValarDragon
Apply matt comments
e7db7e1
@ValarDragon
See what happens by adding fees
1896d2e
@ValarDragon
Merge branch 'main' into dev/consensus_min_gas_fee
f3ffdcb
@ValarDragon
Add genesis logic update
bf1b8bc
@ValarDragon
Try fixing e2e
81ea3fd
@ValarDragon
Add some better logging to find error
efe1326
@ValarDragon
remove stat, fix typo
540eaff
@p0mvn
chore(e2e): update init image on main for #4244
27c6f27
@p0mvn
changes
e71b4ee
@p0mvn
fix more problems
a8a3ad5
@p0mvn
more fixes
52589f1
@p0mvn
lint
b7d5fbd
@p0mvn
twap gebug logs
28219f3
@p0mvn
arithmetic fix
6bb33f8
@github-actions github-actions bot added C:CLI C:x/twap Changes to the twap module labels Feb 16, 2023
Base automatically changed from roman/dev/consensus_min_gas_fee to dev/consensus_min_gas_fee February 16, 2023 10:27
Base automatically changed from dev/consensus_min_gas_fee to main February 16, 2023 14:32
@ValarDragon ValarDragon added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v15.x backport patches to v15.x branch labels Feb 16, 2023
@p0mvn p0mvn force-pushed the roman/e2e-twap-fixes branch from 41a18f3 to 4ccc2e3 Compare February 16, 2023 16:42
@p0mvn p0mvn force-pushed the roman/e2e-twap-fixes branch from 30afaef to fa04f8a Compare February 17, 2023 12:04
@github-actions github-actions bot added C:app-wiring Changes to the app folder C:docs Improvements or additions to documentation C:simulator Edits simulator or simulations C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. C:x/incentives C:x/superfluid C:x/txfees T:CI labels Feb 17, 2023
@p0mvn
Copy link
Member Author

p0mvn commented Feb 17, 2023

in favor of: #4359

@p0mvn p0mvn closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse Awaiting requested review from mattverse mattverse will be requested when the pull request is marked ready for review mattverse is a code owner

@nicolaslara nicolaslara Awaiting requested review from nicolaslara nicolaslara will be requested when the pull request is marked ready for review nicolaslara is a code owner

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu will be requested when the pull request is marked ready for review AlpinYukseloglu is a code owner

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic czarcas7ic will be requested when the pull request is marked ready for review czarcas7ic is a code owner

Assignees
No one assigned
Labels
A:backport/v15.x backport patches to v15.x branch C:app-wiring Changes to the app folder C:CLI C:docs Improvements or additions to documentation C:simulator Edits simulator or simulations C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. C:x/incentives C:x/superfluid C:x/twap Changes to the twap module C:x/txfees T:CI V:state/compatible/backport State machine compatible PR, should be backported
Projects
Osmosis Chain Development
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @ValarDragon