Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dockerfile to use new wasmvm for E2E tests #4811

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Update dockerfile to use new wasmvm for E2E tests #4811

merged 1 commit into from
Mar 31, 2023

Conversation

nicolaslara
Copy link
Contributor

What is the purpose of the change

#4783 broke CI because the docker image doesn't point to the correct wasmvm. Those tests only run on main.

Brief Changelog

Update wasmvm version for E2E

Testing and Verifying

All tests should pass (here and on main)

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@nicolaslara nicolaslara added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Mar 31, 2023
p0mvn
p0mvn approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@p0mvn p0mvn merged commit 3767fa1 into main Mar 31, 2023
@p0mvn p0mvn deleted the nicolas/fix-e2e-docker-for-new-wasm branch March 31, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0mvn p0mvn p0mvn approved these changes

Assignees
No one assigned
Labels
V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolaslara @p0mvn