refactor(osmomath/cl): avoid using broken power function; panic on broken values #5000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #4967
What is the purpose of the change
Addresses #4967 in the context of concentrated liquidity. Keeping #4967 open until completely resolved in the future
The
osmomath.Power
function is broken for base < 1. The reason is that the logarithm function isnegative between zero and 1, and the Exp2(k) is undefined for negative k.
As a result, this function panics if called for base < 1 as it is implemented by
Exp2(base.LogBase2().Mul(exponent))
Brief Changelog
Power
function withPowerInteger
in `x/concentrated-liquidity moduleosmomath.Power
foe base < 1Testing and Verifying
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? yes