[CL][Incentives Query][Bug]: Implement support for CL gauges to incentivized pools query

[AlpinYukseloglu]

Closes: #5186

What is the purpose of the change

This PR expands our incentivized pools query to be inclusive of incentivized CL pools.

Testing and Verifying

• Changes are tested in x/pool-incentives/keeper/grpc_query_test.go

Documentation and Release Note

• Does this pull request introduce a new feature or user-facing behavior changes?
• Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

• Specification (x/{module}/README.md)
• Osmosis documentation site
• Code comments?
• N/A

[p0mvn]

On mainnet, epoch duration is 1 day, and we also have 1-day uptime. How are we going to differentiate between internal per-epoch gauges and 1 day uptime gauges?

[AlpinYukseloglu]

We don't need to differentiate, right? My understanding is that the goal of the query is to get all the incentivized pools, so as long as the 1-day period is included in the list then all CL pools will be part of the query response.

This section simply ensures that if the epoch duration already exists as a lockup duration (e.g. as on mainnet), then it does not add it as a duplicate.

[p0mvn]

FYI, from @jonator

Yeah we need to make sure it only refers to pools and gauges that are internally incentivized via mint incentives

For external incentives, we handle those in the opposite direction: by querying the gauges and linking those to pools

(Which, a separate topic, causes a lot of performance issues)

Like in hindsight, we could have reduced complexity by having the node return all gauges for a pool, internal and external

[mattverse]

Suggested change

	epochDuration := q.incentivesKeeper.GetEpochInfo(sdkCtx).Duration
	epochAlreadyLockable := false
	for _, lockableDuration := range lockableDurations {
	if lockableDuration == epochDuration {
	epochAlreadyLockable = true
	break
	}
	}
	// Ensure that we only add epoch duration if it does not already exist as a lockable duration.
	if !epochAlreadyLockable {
	lockableDurations = append(lockableDurations, epochDuration)
	}
	epochDuration := q.incentivesKeeper.GetEpochInfo(sdkCtx).Duration
	for _, lockableDuration := range lockableDurations {
	if lockableDuration == epochDuration {
	lockableDurations = append(lockableDurations, epochDuration)
	break
	}
	}

[AlpinYukseloglu]

This change seems to add epoch time to lockable durations only if it already exists in there - we want the exact opposite no?

I would like to converge on internal vs external incentives included discussion to make sure this works for FE