Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reproduce negative coin panic due to negative range accumulators #5857

Merged
merged 1 commit into from
Jul 17, 2023
Merged

test: reproduce negative coin panic due to negative range accumulators #5857

merged 1 commit into from
Jul 17, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jul 17, 2023

Progress towards #5854

What is the purpose of the change

This PR reproduces a negative coin panic stemming from the negative range accumulator whenever
lower tick accumulator is greater than upper tick accumulator and current tick is above the position's range.

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • x ] Code comments?
  • N/A

@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v16.x backport patches to v16.x branch A:no-changelog labels Jul 17, 2023
@p0mvn p0mvn marked this pull request as ready for review July 17, 2023 16:04
@p0mvn p0mvn requested a review from czarcas7ic as a code owner July 17, 2023 16:04
@ValarDragon
Copy link
Member

Nice job!

AlpinYukseloglu
AlpinYukseloglu approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@AlpinYukseloglu AlpinYukseloglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to add this!

@ValarDragon ValarDragon merged commit c26756d into main Jul 17, 2023
@ValarDragon ValarDragon deleted the roman/neg-range-repro branch July 17, 2023 16:41
mergify bot pushed a commit that referenced this pull request Jul 17, 2023
@p0mvn @mergify
test: reproduce negative coin panic due to negative range accumulators (
ae4c947 
#5857)

(cherry picked from commit c26756d)
@mergify mergify bot mentioned this pull request Jul 17, 2023
Merged
ValarDragon pushed a commit that referenced this pull request Jul 17, 2023
@mergify @p0mvn
test: reproduce negative coin panic due to negative range accumulators (
7285dd2 
#5857) (#5859)

(cherry picked from commit c26756d)

Co-authored-by: Roman <roman@osmosis.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlpinYukseloglu AlpinYukseloglu AlpinYukseloglu approved these changes

@ValarDragon ValarDragon ValarDragon approved these changes

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic czarcas7ic is a code owner

Assignees
No one assigned
Labels
A:backport/v16.x backport patches to v16.x branch A:no-changelog C:x/concentrated-liquidity V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p0mvn @ValarDragon @AlpinYukseloglu