refactor: reduce number of returns for creating full range position #6004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:x/lockup
C:x/gamm
|
devbot add changelog api reduce number of returns for creating full range position |
p0mvn
added
V:state/compatible/backport
p0mvn
requested review from
mattverse,
stackman27,
AlpinYukseloglu and
czarcas7ic
as code owners
czarcas7ic
approved these changes
Aug 9, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…6004) * refactor: reduce number of returns for creating full range position * update changelog --------- Co-authored-by: devbot-wizard <141283918+devbot-wizard@users.noreply.github.com> (cherry picked from commit 07c8556) # Conflicts: # CHANGELOG.md # app/upgrades/v17/upgrades.go # x/concentrated-liquidity/lp_test.go # x/concentrated-liquidity/position.go # x/concentrated-liquidity/position_test.go # x/superfluid/keeper/export_test.go # x/superfluid/keeper/migrate.go
p0mvn
added a commit
that referenced
this pull request
Aug 10, 2023
p0mvn
added a commit
that referenced
this pull request
Aug 29, 2023
…6004) * refactor: reduce number of returns for creating full range position * update changelog --------- Co-authored-by: devbot-wizard <141283918+devbot-wizard@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards: #5984
What is the purpose of the change
Refactoring full range position creation to return 1 struct instead of 4 values.
Testing and Verifying
This change is already covered by existing tests
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)