chore(lint): fix all linter issues; add return check; re-enable in CI #6112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:x/gamm
p0mvn
added
V:state/compatible/backport
p0mvn
commented
Aug 18, 2023
p0mvn
requested review from
a team,
nicolaslara,
AlpinYukseloglu,
mattverse,
stackman27 and
czarcas7ic
as code owners
ValarDragon
reviewed
Aug 18, 2023
mattverse
approved these changes
Aug 21, 2023
| - name: function-result-limit | ||
| severity: warning | ||
| disabled: false | ||
| arguments: [4] |
There was a problem hiding this comment.
just curious, what's the args 4 here?
There was a problem hiding this comment.
It limits the number of returns to 4. I added a comment to explain this
p0mvn
commented
Aug 21, 2023
|
I'm happy for you to just merge this @p0mvn when things are ready |
p0mvn
added
A:backport/v18.x
p0mvn
force-pushed
the
roman/max-return-linter
branch
from
80170b7 to
c19f808
Compare
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
…#6112) * linter: max return values * updates * fix all linter errors * attempt to fix linter in CI * remove depguard * godocs * move unused twap helper to test export * bug * bring back getAllHistoricalPoolIndexedTWAPs and add nolint * Update .golangci.yml * fix more issues * conflict * new lints (cherry picked from commit 714f573) # Conflicts: # x/concentrated-liquidity/simulation/sim_msgs.go # x/concentrated-liquidity/swaps.go # x/incentives/keeper/distribute.go # x/superfluid/keeper/epoch.go # x/twap/store.go
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
…#6112) * linter: max return values * updates * fix all linter errors * attempt to fix linter in CI * remove depguard * godocs * move unused twap helper to test export * bug * bring back getAllHistoricalPoolIndexedTWAPs and add nolint * Update .golangci.yml * fix more issues * conflict * new lints (cherry picked from commit 714f573) # Conflicts: # x/concentrated-liquidity/swaps.go # x/incentives/keeper/distribute.go
This was referenced Aug 30, 2023
nicolaslara
pushed a commit
that referenced
this pull request
Aug 31, 2023
…#6112) * linter: max return values * updates * fix all linter errors * attempt to fix linter in CI * remove depguard * godocs * move unused twap helper to test export * bug * bring back getAllHistoricalPoolIndexedTWAPs and add nolint * Update .golangci.yml * fix more issues * conflict * new lints
p0mvn
added a commit
that referenced
this pull request
Sep 1, 2023
p0mvn
added a commit
that referenced
this pull request
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: ##6111, #5984
What is the purpose of the change
One of the previous PRs broke linter in CI. As a result, we have a lot of local failures. This PR fixes all of them
Additionally, it adds a new arg check linter via
reviveLastly, it also removes a
depguardlinter. This linter configures an allow and a deny list of imports. Currently, we don't have that configured and there are numerous failures. Personally, I don't see it as something useful. If someone wants it, please configure it in a separate PR.No changelog label is set as no exported API is broken.
Testing and Verifying
This change is already covered by existing tests
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)