Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v19 superfluid fix #6190

Merged
merged 3 commits into from
Aug 28, 2023
Merged

v19 superfluid fix #6190

merged 3 commits into from
Aug 28, 2023

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Aug 27, 2023 •
edited
Loading

@github-actions github-actions bot added C:x/lockup C:app-wiring Changes to the app folder labels Aug 27, 2023
@ValarDragon ValarDragon changed the title Fix v18 handler v19 superfluid fix Aug 27, 2023
@czarcas7ic czarcas7ic added the V:state/breaking State machine breaking PR label Aug 27, 2023
@czarcas7ic
Copy link
Member

devbot help

@devbot-wizard
Copy link
Collaborator

Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:

  • devbot fix: Fix basic errors in the PR. (e.g. imports, changelog conflicts, go mod conflicts)
  • devbot merge base: Merge the base branch into the PR branch.
  • devbot add changelog [misc/feat/bug/api/sec] [message]: Add a changelog entry to the PR. (e.g. devbot add changelog feat Added a new feature)
    • If message is blank, defaults to PR title.
  • devbot re-pr: Re-PR the PR, useful for external contributors where we have no edit perms.

@czarcas7ic
Copy link
Member

devbot add changelog bug v19 upgrade handler superfluid fix

czarcas7ic
czarcas7ic approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the understanding that the best way to test this is via a state exported testnet and not via a gotest

@ValarDragon ValarDragon merged commit 5509514 into main Aug 28, 2023
1 check passed
@ValarDragon ValarDragon deleted the dev/fix_v19 branch August 28, 2023 01:56
@ValarDragon ValarDragon added the A:backport/v19.x backport patches to v19.x branch label Aug 28, 2023
mergify bot pushed a commit that referenced this pull request Aug 28, 2023
@ValarDragon @mergify
v19 superfluid fix (#6190)
e003dd5 
* Fix v18 handler

* Synth denom

* update changelog

---------

Co-authored-by: devbot-wizard <141283918+devbot-wizard@users.noreply.github.com>
(cherry picked from commit 5509514)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Aug 28, 2023
Merged
ValarDragon added a commit that referenced this pull request Aug 28, 2023
@mergify @ValarDragon @czarcas7ic
v19 superfluid fix (backport #6190) (#6193)
c395875 
* v19 superfluid fix (#6190)

* Fix v18 handler

* Synth denom

* update changelog

---------

Co-authored-by: devbot-wizard <141283918+devbot-wizard@users.noreply.github.com>
(cherry picked from commit 5509514)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Adam Tucker <adam@osmosis.team>
nicolaslara pushed a commit that referenced this pull request Aug 31, 2023
@ValarDragon @devbot-wizard @nicolaslara
v19 superfluid fix (#6190)
a6c7723 
* Fix v18 handler

* Synth denom

* update changelog

---------

Co-authored-by: devbot-wizard <141283918+devbot-wizard@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@stackman27 stackman27 Awaiting requested review from stackman27

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu is a code owner

Assignees
No one assigned
Labels
A:backport/v19.x backport patches to v19.x branch C:app-wiring Changes to the app folder C:x/lockup V:state/breaking State machine breaking PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValarDragon @czarcas7ic @devbot-wizard