Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #627

Closed
wants to merge 1 commit into from
Closed

Update README.md #627

wants to merge 1 commit into from

Conversation

faddat
Copy link
Member

@faddat faddat commented Nov 28, 2021

Description

The beginblocker for sdk 42.9 caused incompatiblity. Will sync from 3.0.0 and keep this up to date as a canonical full sync from genesis.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

The beginblocker for sdk 42.9 caused incompatiblity.  Will sync from 3.0.0 and keep this up to date as a canonical full sync from genesis.
@codecov-commenter
Copy link

Codecov Report

Merging #627 (bdcbd09) into main (d31bb5b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   18.44%   18.44%           
=======================================
  Files         172      172           
  Lines       24235    24235           
=======================================
  Hits         4470     4470           
  Misses      19000    19000           
  Partials      765      765           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d31bb5b...bdcbd09. Read the comment docs.

@@ -22,7 +22,7 @@ Then exit and re-enter your shell.
```bash
git clone https://github.com/osmosis-labs/osmosis
cd osmosis
git checkout v3.1.0
git checkout v3.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure v3.0.0 is broken 😅

cc @UnityChaos

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we keep this at v3.1.0 looks good to merge to me

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmmm, ok so I had to actually go backwards to v2.0.0, let me check in on that sync

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, v3.0.0 has this bug: cosmos/cosmos-sdk#9800 because we forgot to init the capability module.

@faddat
Copy link
Member Author

faddat commented Dec 2, 2021

this should be considered blocked by #631

@faddat faddat mentioned this pull request Dec 2, 2021
@faddat
Copy link
Member Author

faddat commented Dec 9, 2021

Since this is for normal folk, and is a quickstart I am going to have it grab from quicksync and run v4.2.0.

When statesync works, I'm going to make a build process that:

  • State syncs it!
  • Tosses the bin in an electron app
  • Electron app contains the default UI

Boom, sovereign osmosis users.

@faddat
Copy link
Member Author

faddat commented Dec 10, 2021

It is reasonable to close this in favor of #647

@faddat faddat closed this Dec 10, 2021
@ValarDragon ValarDragon deleted the faddat-patch-2 branch December 11, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants