bug: send non osmo txfees to community pool instead of stakers #6426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
devbot help |
|
Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:
|
|
devbot add changelog bug |
czarcas7ic
requested review from
nicolaslara,
p0mvn and
AlpinYukseloglu
as code owners
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
* fix non osmo txfees to community pool instead of stakers * update changelog * update fee decorator test * change version to alpine * add comment * uncomment test * fix script to pull alpine image * update README * Update empty_upgrade_handler_gen.sh --------- Co-authored-by: devbot-wizard <141283918+devbot-wizard@users.noreply.github.com> (cherry picked from commit 2bb6be9) # Conflicts: # CHANGELOG.md # tests/e2e/containers/config.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Txfees collected in non osmo should be swapped to osmo at epoch and sent to the community pool. The taker fee feature implemented a new module account that collects non osmo funds, swaps them, and sends the to stakers instead. This module account was mistakenly used in the txfees logic instead of the old community pool txfees collector.
Very low impact from this bug, and simply swapping the module accounts fixes this.