[Valset]: Fix weight calculations to be based on tokens instead of shares #6699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
approved these changes
Oct 13, 2023
… that modified dependencies locally
…com/osmosis-labs/osmosis into alpo/fix-valset-undelegation-shares
|
Important Notice This PR modifies an in-repo Go module. It is one of:
The dependent Go modules, especially the root one, will have to be Please follow the instructions below:
Please let us know if you need any help. |
… that modified dependencies locally
mergify bot
pushed a commit
that referenced
this pull request
Oct 14, 2023
…ares (#6699) * fix weight calculations to be based on tokens instead of shares * changelog * add comments and clean up tests * Auto: update go.mod after push to alpo/fix-valset-undelegation-shares that modified dependencies locally * switch rounding to bankers * Auto: update go.mod after push to alpo/fix-valset-undelegation-shares that modified dependencies locally --------- Co-authored-by: github-actions <github-actions@github.com> (cherry picked from commit cf159ac)
czarcas7ic
pushed a commit
that referenced
this pull request
Oct 14, 2023
…ares (#6699) (#6700) * fix weight calculations to be based on tokens instead of shares * changelog * add comments and clean up tests * Auto: update go.mod after push to alpo/fix-valset-undelegation-shares that modified dependencies locally * switch rounding to bankers * Auto: update go.mod after push to alpo/fix-valset-undelegation-shares that modified dependencies locally --------- Co-authored-by: github-actions <github-actions@github.com> (cherry picked from commit cf159ac) Co-authored-by: Alpo <62043214+AlpinYukseloglu@users.noreply.github.com>
pysel
pushed a commit
that referenced
this pull request
Oct 17, 2023
…ares (#6699) * fix weight calculations to be based on tokens instead of shares * changelog * add comments and clean up tests * Auto: update go.mod after push to alpo/fix-valset-undelegation-shares that modified dependencies locally * switch rounding to bankers * Auto: update go.mod after push to alpo/fix-valset-undelegation-shares that modified dependencies locally --------- Co-authored-by: github-actions <github-actions@github.com>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Current valset undelegation logic has a bug where it calculates the amount to undelegate based on validator shares instead of their underlying tokens. Since the value of shares are nonfungible and highly variable across validators, this is a fundamentally incorrect way to calculate the correct portion of a valset that corresponds to a given validator. For instance, if a user has delegated 10 shares each to 10 validators and one of the validators gets slashed for 20% of its stake, the current implementation would continue to treat the slashed validator as 10% of the delegator's set.
This PR fixes valset undelegation logic so it works with tokens instead of shares.
Testing and Verifying
The helper that was causing the root issue is fixed and tested in
keeper_test.goDocumentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)