Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: arb filter for new authz exec swap #7210

Merged
merged 4 commits into from
Dec 26, 2023
Merged

refactor: arb filter for new authz exec swap #7210

merged 4 commits into from
Dec 26, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Dec 26, 2023 •
edited
Loading

@p0mvn p0mvn changed the title updates refactor: arb filter for new authz exec swap Dec 26, 2023
@p0mvn p0mvn marked this pull request as ready for review December 26, 2023 07:59
czarcas7ic
czarcas7ic approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@p0mvn p0mvn merged commit fec85d5 into v21.1.x Dec 26, 2023
1 check passed
@p0mvn p0mvn deleted the arb-filter branch December 26, 2023 08:16
p0mvn added a commit that referenced this pull request Dec 26, 2023
@p0mvn
refactor: arb filter for new authz exec swap (#7210)
fff2dc8 
* refactor: arb filter for new authz exec swap

* updates

* updates

* updates
nicolaslara
nicolaslara reviewed Dec 26, 2023
View reviewed changes
x/txfees/keeper/txfee_filters/arb_tx_test.go
Denom: "ibc/D1542AA8762DB13087D8364F3EA6509FD6F009A34F00426AF9E4F9FA85CBBF1F",
},
OutputDenom: "ibc/D1542AA8762DB13087D8364F3EA6509FD6F009A34F00426AF9E4F9FA85CBBF1F",
Slippage: txfee_filters.Slippage{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the contracts allow to set slippage as a percentage instead of MinOutputAmount. Maybe we should consider that as an option too?

nicolaslara
nicolaslara reviewed Dec 26, 2023
View reviewed changes
x/txfees/keeper/txfee_filters/arb_tx.go
return false
}

return true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to be more strict here we can check that the input and output denoms are either (1) the same, or (2) in a list of equivalent denoms (usdc/usdt/axlusdc/etc)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work for now, but we are considering any contract swap as an attack, instead of just arbs

czarcas7ic pushed a commit that referenced this pull request Dec 29, 2023
@p0mvn @czarcas7ic
refactor: arb filter for new authz exec swap (#7210)
48a9c68 
* refactor: arb filter for new authz exec swap

* updates

* updates

* updates
czarcas7ic added a commit that referenced this pull request Dec 30, 2023
@czarcas7ic @ValarDragon @p0mvn
chore: catch up main to v21.1.x (#7215)
c5a5147 
* Reduce discrepancy in fee simulation

* Update

* State compatible applyFuncIfNoError event reduction

* Update osmoutils/epochs versions

* Update SDK version

* One more epoch speedup

* Speedup core loop of epoch

* fix test (#7197)

* refactor: auto-set timeout-commit to 4s for faster block times (#7196)

* updates (#7192)

* refactor: auto-set timeout-commit to 4s for faster block times (backport #7180)

* changelog

* Revert "updates (#7192)"

This reverts commit 6cc26f9.

* lint

* Update changelog

* Update changelog

* changelog

* Speedup multiplication

* Try scratch slice

* refactor: arb filter for new authz exec swap (#7210)

* refactor: arb filter for new authz exec swap

* updates

* updates

* updates

* clean up

* Auto: update go.mod after push to adam/v21.1.x-merge-to-main that modified dependencies locally

* add 21.1.5 to changelog

* update comment

---------

Co-authored-by: Dev Ojha <dojha@berkeley.edu>
Co-authored-by: Roman <roman@osmosis.team>
Co-authored-by: github-actions <github-actions@github.com>
mergify bot pushed a commit that referenced this pull request Dec 30, 2023
@czarcas7ic @mergify
chore: catch up main to v21.1.x (#7215)
3c81a12 
* Reduce discrepancy in fee simulation

* Update

* State compatible applyFuncIfNoError event reduction

* Update osmoutils/epochs versions

* Update SDK version

* One more epoch speedup

* Speedup core loop of epoch

* fix test (#7197)

* refactor: auto-set timeout-commit to 4s for faster block times (#7196)

* updates (#7192)

* refactor: auto-set timeout-commit to 4s for faster block times (backport #7180)

* changelog

* Revert "updates (#7192)"

This reverts commit 6cc26f9.

* lint

* Update changelog

* Update changelog

* changelog

* Speedup multiplication

* Try scratch slice

* refactor: arb filter for new authz exec swap (#7210)

* refactor: arb filter for new authz exec swap

* updates

* updates

* updates

* clean up

* Auto: update go.mod after push to adam/v21.1.x-merge-to-main that modified dependencies locally

* add 21.1.5 to changelog

* update comment

---------

Co-authored-by: Dev Ojha <dojha@berkeley.edu>
Co-authored-by: Roman <roman@osmosis.team>
Co-authored-by: github-actions <github-actions@github.com>
(cherry picked from commit c5a5147)

# Conflicts:
#	go.mod
#	go.sum
#	osmomath/go.sum
czarcas7ic added a commit that referenced this pull request Dec 30, 2023
@mergify @czarcas7ic
chore: catch up main to v21.1.x (backport #7215) (#7216)
6a76a5c 
* chore: catch up main to v21.1.x (#7215)

* Reduce discrepancy in fee simulation

* Update

* State compatible applyFuncIfNoError event reduction

* Update osmoutils/epochs versions

* Update SDK version

* One more epoch speedup

* Speedup core loop of epoch

* fix test (#7197)

* refactor: auto-set timeout-commit to 4s for faster block times (#7196)

* updates (#7192)

* refactor: auto-set timeout-commit to 4s for faster block times (backport #7180)

* changelog

* Revert "updates (#7192)"

This reverts commit 6cc26f9.

* lint

* Update changelog

* Update changelog

* changelog

* Speedup multiplication

* Try scratch slice

* refactor: arb filter for new authz exec swap (#7210)

* refactor: arb filter for new authz exec swap

* updates

* updates

* updates

* clean up

* Auto: update go.mod after push to adam/v21.1.x-merge-to-main that modified dependencies locally

* add 21.1.5 to changelog

* update comment

---------

Co-authored-by: Dev Ojha <dojha@berkeley.edu>
Co-authored-by: Roman <roman@osmosis.team>
Co-authored-by: github-actions <github-actions@github.com>
(cherry picked from commit c5a5147)

# Conflicts:
#	go.mod
#	go.sum
#	osmomath/go.sum

* go mod update

* update go mods from v21.x

---------

Co-authored-by: Adam Tucker <adam@osmosis.team>
Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
p0mvn added a commit that referenced this pull request Jan 2, 2024
@p0mvn @czarcas7ic
refactor: arb filter for new authz exec swap (#7210) (#7211)
2f3191b 
* refactor: arb filter for new authz exec swap (#7210)

* refactor: arb filter for new authz exec swap

* updates

* updates

* updates

* Update launch.json

---------

Co-authored-by: Adam Tucker <adam@osmosis.team>
mergify bot pushed a commit that referenced this pull request Jan 2, 2024
@p0mvn @mergify
refactor: arb filter for new authz exec swap (#7210) (#7211)
9e96164 
* refactor: arb filter for new authz exec swap (#7210)

* refactor: arb filter for new authz exec swap

* updates

* updates

* updates

* Update launch.json

---------

Co-authored-by: Adam Tucker <adam@osmosis.team>
(cherry picked from commit 2f3191b)
@czarcas7ic czarcas7ic added A:backport/v21.x backport patches to v21.x branch and removed A:backport/v21.x backport patches to v21.x branch labels Jan 10, 2024
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaslara nicolaslara nicolaslara left review comments

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu is a code owner

Assignees
No one assigned
Labels
C:x/txfees
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p0mvn @nicolaslara @czarcas7ic