-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribution, expand the ignored distributios set #7250
Conversation
return true, totalDistrCoins, err | ||
} | ||
|
||
// Remove some spam gauges that are not worth distributing. (We ignore the denom stake because of tests.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(We ignore the denom stake because of tests.)
LOL, cant we just inc the tests to be greater than 100??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah but its pain
@@ -713,6 +698,28 @@ func (k Keeper) distributeInternal( | |||
return totalDistrCoins, err | |||
} | |||
|
|||
func (k Keeper) skipSpamGaugeDistribute(ctx sdk.Context, locks []*lockuptypes.PeriodLock, gauge types.Gauge, totalDistrCoins sdk.Coins, remainCoins sdk.Coins) (bool, sdk.Coins, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be worth creating unit test for this as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 5cf383a
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
Expands the set of gauges we ignore, as we are now no longer concerned about state compat in main.
This changes
to
Requiring a gauge to distribute at least 100 coins, for any pool. Ignores "stake" to avoid fixing all the tests.