Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: go mod updates #7268

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix: go mod updates #7268

merged 1 commit into from
Jan 8, 2024

Conversation

czarcas7ic
Copy link
Member

Closes: #XXX

What is the purpose of the change

The action we were using to update go mods was erroring on some modules due to not having the proper replace lines. You will notice that some of the osmosis module imports are outdated and were not touched by the action.

This PR:

  1. Fixes the import issues
  2. Changes the action script to not require manually definitions of where the imports are, so it is expandable if we decide to import an osmosis module elsewhere.

NOTE: When this gets backported, the action should be run again, and it will target the osmo packages in v21.x instead

@czarcas7ic czarcas7ic added V:state/compatible/backport State machine compatible PR, should be backported A:no-changelog A:backport/v21.x backport patches to v21.x branch labels Jan 8, 2024
@czarcas7ic czarcas7ic marked this pull request as ready for review January 8, 2024 16:36
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@p0mvn p0mvn merged commit d3034bb into main Jan 8, 2024
1 check passed
@p0mvn p0mvn deleted the adam/go-mod-update branch January 8, 2024 17:30
mergify bot pushed a commit that referenced this pull request Jan 8, 2024
(cherry picked from commit d3034bb)

# Conflicts:
#	go.mod
#	go.sum
#	osmomath/go.mod
#	osmomath/go.sum
#	osmoutils/go.mod
#	osmoutils/go.sum
#	scripts/update-go-mod.sh
#	x/epochs/go.mod
#	x/epochs/go.sum
p0mvn added a commit that referenced this pull request Jan 8, 2024
p0mvn added a commit that referenced this pull request Jan 8, 2024
* fix: go mod updates (backport #7268)

* Auto: update go.mod after push to mergify/bp/v21.x/pr-7268 that modified dependencies locally

---------

Co-authored-by: Roman <roman@osmosis.team>
Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v21.x backport patches to v21.x branch A:no-changelog C:x/epochs T:build V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants