Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing interface to osmosis.incentives.CreateGroupsProposal protobuf #7385

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

NoahSaso
Copy link
Contributor

@NoahSaso NoahSaso commented Jan 30, 2024

What is the purpose of the change

The osmosis.incentives.CreateGroupsProposal protobuf type is missing an interface implementation statement.

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks :)

@mattverse mattverse added the V:state/breaking State machine breaking PR label Jan 30, 2024
@czarcas7ic
Copy link
Member

@NoahSaso can you run make proto-all and then push those changes

@NoahSaso
Copy link
Contributor Author

@NoahSaso can you run make proto-all and then push those changes

gotchu 🤝

@mattverse
Copy link
Member

@NoahSaso can you run make proto-all and then push those changes

@czarcas7ic I've noticed our check-proto CI failing when an external contributor has created a PR 🤔 We should definitely come back and fix it but should be good to merge for now :)

@mattverse mattverse merged commit de82581 into osmosis-labs:main Feb 1, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/incentives V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants