Arbitrage tx mempool filter #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #741 +/- ##
==========================================
- Coverage 18.73% 18.72% -0.01%
==========================================
Files 172 174 +2
Lines 23908 23932 +24
==========================================
+ Hits 4478 4481 +3
- Misses 18655 18675 +20
- Partials 775 776 +1
Continue to review full report at Codecov.
|
UnityChaos
approved these changes
Jan 12, 2022
ValarDragon
added a commit
that referenced
this pull request
Jan 13, 2022
* Add Arb checktx filter, to raise gas * Add config params for min fee for arbitrage tx * Small improvements, add changelog * Fix bug in swap_msg logic
lostak
referenced
this pull request
Jun 15, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #723
Description
This PR adds a mempool filter for arbitrage txs. When its hit, it charges a separate gas price, as specified in the full nodes application config. This defaults to
0 uosmoif not set in the app.toml, but the app.toml defaults to.005uosmo/gas.The detection algorithm for arbitrage txs does have some false positives, and likely many false negatives. The false positives are described in the code comments, and I think are pretty miniscule. (Only thing I can see hitting it is a service that batches many users swap / LP positions together. Such a batching service seems like it can maintain connections to folks with lower fees though)
For contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer