Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make staking keeper passing more idiomatic #742

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Jan 9, 2022

The whole point of the keepers.go refactor was to make the keeper on the app a pointer =)
See line 142, app.StakingKeeper = &stakingKeeper. This just makes this section cleaner


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/) - N/A
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md - N/A
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

Codecov Report

Merging #742 (36e702f) into main (bc65a83) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #742   +/-   ##
=======================================
  Coverage   18.73%   18.73%           
=======================================
  Files         172      172           
  Lines       23908    23908           
=======================================
  Hits         4478     4478           
  Misses      18655    18655           
  Partials      775      775           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc65a83...36e702f. Read the comment docs.

@ValarDragon ValarDragon requested a review from mattverse January 18, 2022 03:08
@ValarDragon ValarDragon merged commit 42996df into main Jan 18, 2022
@ValarDragon ValarDragon deleted the dev/keepers_more_idiomatic branch January 18, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants