Reduce Sqrt calls in TickToSqrtPrice #7599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
added
V:state/compatible/backport
ValarDragon
requested review from
czarcas7ic,
p0mvn and
AlpinYukseloglu
as code owners
mattverse
approved these changes
Feb 29, 2024
|
I appreciate the review! |
mergify bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
* Reduce Sqrt calls in TickToSqrtPrice * Move error to types (cherry picked from commit 5a763c1)
mergify bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
* Reduce Sqrt calls in TickToSqrtPrice * Move error to types (cherry picked from commit 5a763c1)
mergify bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
* Reduce Sqrt calls in TickToSqrtPrice * Move error to types (cherry picked from commit 5a763c1)
This was referenced Mar 6, 2024
ValarDragon
added a commit
that referenced
this pull request
Mar 6, 2024
ValarDragon
added a commit
that referenced
this pull request
Mar 6, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the number of sqrt invocations in TickToSqrtPrice. Depending on the way the error goes, we save either 1 or 2 Sqrt calls (before there were always 4).
This is basic from being a binary search. We should do some analysis in the future, to remove the need from computing either boundary sqrt. I think we should be able to get away without having either, and thus just need 1 or 2 comparisons to get which partition we need to be in. (Versus our now 3-4)