protorev: Remove unneeded AllBalances call #7605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
requested review from
czarcas7ic,
p0mvn and
AlpinYukseloglu
as code owners
p0mvn
approved these changes
Feb 24, 2024
p0mvn
reviewed
Feb 24, 2024
Comment on lines
+22
to
23
| GetBalance(ctx sdk.Context, addr sdk.AccAddress, denom string) sdk.Coin | ||
| GetAllBalances(ctx sdk.Context, addr sdk.AccAddress) sdk.Coins |
There was a problem hiding this comment.
Is GetAllBalances still needed or can be removed?
There was a problem hiding this comment.
Good question, let me check
There was a problem hiding this comment.
We still need it for a query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor protorev speedup, by removing an AllBalances call that happens after protorev has been determined to have non-zero minimum profit.
This is a 30ms speedup on a 2000 bloc syncs in IAVL v1 nfn, so very minor. Just came across it as I am going through the logic.