Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add nostrip compilr flag to attach debug symbols #7759

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Mar 16, 2024

Closes: #XXX

What is the purpose of the change

This instructs the compiler to attach the debug symbols to a go binary. This is useful when profiling the system with external non-Go tools such as perf that offer visibility into kernel

Summary by CodeRabbit

  • Refactor
    • Improved the build process for development environments to enhance debugging capabilities.

Copy link
Contributor

coderabbitai bot commented Mar 16, 2024

Walkthrough

The update introduces a modification to the build-dev-build target within the build.mk script, specifically enhancing the go build command. This enhancement involves the addition of the -gcflags "all=-N -l" option, which significantly changes how the build process is executed, aiming to improve development builds.

Changes

File Change Summary
scripts/.../build.mk Added -gcflags "all=-N -l" to go build in build-dev-build target

🐇✨
In the realm of code, under the moon's soft glow,
A subtle change takes flight, with a gentle bow.
-gcflags weaves its magic, both deep and wide,
Crafting builds anew, with a rabbit as your guide.
Through fields of bits, our journey does not stall,
For in every line of code, a rabbit's wisdom calls.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@p0mvn p0mvn added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks A:no-changelog V:state/compatible/backport State machine compatible PR, should be backported A:backport/v23.x backport patches to v23.x branch and removed T:build V:state/compatible/no_backport State machine compatible PR, depends on prior breaks labels Mar 16, 2024
@p0mvn p0mvn closed this Mar 16, 2024
@p0mvn p0mvn reopened this Mar 16, 2024
@p0mvn p0mvn marked this pull request as ready for review March 16, 2024 23:12
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ca7c0b8 and cbbfb66.
Files selected for processing (1)
  • scripts/makefiles/build.mk (1 hunks)
Additional comments: 1
scripts/makefiles/build.mk (1)
  • 51-51: The addition of -gcflags "all=-N -l" to the build-dev-build target is a valuable change for enhancing debugging capabilities by ensuring debug symbols are preserved. This is particularly useful when using external profiling tools. However, it's important to note that disabling optimizations and inlining can impact the performance of the development build. It would be beneficial to document this change, highlighting its purpose and potential impact on build performance, to ensure developers are aware and can make informed decisions when using this build target.

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY! I have wondered how to get debug symbols

@ValarDragon ValarDragon merged commit be76d37 into main Mar 16, 2024
1 check passed
@ValarDragon ValarDragon deleted the roman/debug-symbols branch March 16, 2024 23:41
mergify bot pushed a commit that referenced this pull request Mar 16, 2024
* chore: add nostrip compilr flag to attach debug symbols

* updates

(cherry picked from commit be76d37)
mergify bot pushed a commit that referenced this pull request Mar 16, 2024
* chore: add nostrip compilr flag to attach debug symbols

* updates

(cherry picked from commit be76d37)
p0mvn added a commit that referenced this pull request Mar 17, 2024
* chore: add nostrip compilr flag to attach debug symbols

* updates

(cherry picked from commit be76d37)

Co-authored-by: Roman <roman@osmosis.team>
p0mvn added a commit that referenced this pull request Mar 17, 2024
* chore: add nostrip compilr flag to attach debug symbols

* updates

(cherry picked from commit be76d37)

Co-authored-by: Roman <roman@osmosis.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v23.x backport patches to v23.x branch A:no-changelog T:build V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants