-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add nostrip compilr flag to attach debug symbols #7759
Conversation
WalkthroughThe update introduces a modification to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- scripts/makefiles/build.mk (1 hunks)
Additional comments: 1
scripts/makefiles/build.mk (1)
- 51-51: The addition of
-gcflags "all=-N -l"
to thebuild-dev-build
target is a valuable change for enhancing debugging capabilities by ensuring debug symbols are preserved. This is particularly useful when using external profiling tools. However, it's important to note that disabling optimizations and inlining can impact the performance of the development build. It would be beneficial to document this change, highlighting its purpose and potential impact on build performance, to ensure developers are aware and can make informed decisions when using this build target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY! I have wondered how to get debug symbols
* chore: add nostrip compilr flag to attach debug symbols * updates (cherry picked from commit be76d37)
* chore: add nostrip compilr flag to attach debug symbols * updates (cherry picked from commit be76d37)
Closes: #XXX
What is the purpose of the change
This instructs the compiler to attach the debug symbols to a go binary. This is useful when profiling the system with external non-Go tools such as perf that offer visibility into kernel
Summary by CodeRabbit