Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic versioning for osmosis v4.x #780

Merged
merged 12 commits into from
Jan 28, 2022
Merged

Semantic versioning for osmosis v4.x #780

merged 12 commits into from
Jan 28, 2022

Conversation

faddat
Copy link
Member

@faddat faddat commented Jan 23, 2022

Closes: #621

Description

I found an import of app.go that wasn't changed to v4, and changed that.

Also, I changed some import paths in the .proto files and then ran make proto-all.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v4.x@69ec73c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v4.x     #780   +/-   ##
=======================================
  Coverage        ?   20.07%           
=======================================
  Files           ?      164           
  Lines           ?    23253           
  Branches        ?        0           
=======================================
  Hits            ?     4667           
  Misses          ?    17830           
  Partials        ?      756           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ec73c...f3095d8. Read the comment docs.

@faddat faddat marked this pull request as draft January 23, 2022 02:43
@faddat
Copy link
Member Author

faddat commented Jan 23, 2022

I'll fix up the linting tomorrow :)

}


option go_package = "github.com/osmosis-labs/osmosis/x/gamm/types";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this part is missed for the sem ver!

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace line27 of scripts/generate-proto.sh with

cp -r ./github.com/osmosis-labs/osmosis/v*/x/* x/

I noticed that proto files were being generated in a separate directory, changing the script file with the line above should do the trick!

If your busy with other stuff going on, I can also this PR over!

@faddat
Copy link
Member Author

faddat commented Jan 27, 2022

Hi Matt, we spoke last night and I said this was ready to go 😝 -- what I did not realize was that it is ready to go only:

.... in goland

.... on my computer (but not here)

I'll push now

@ValarDragon ValarDragon mentioned this pull request Jan 27, 2022
5 tasks
@faddat
Copy link
Member Author

faddat commented Jan 27, 2022

Another thing that I did is make this version:

  • use tendermint 0.34.15
  • tm-db v0.6.6
  • cosmos/gorocksdb v1.2.0

@faddat faddat marked this pull request as ready for review January 27, 2022 05:28
@ValarDragon
Copy link
Member

LGTM once lint issues are fixed! (I believe just commenting out errcheck right?)

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just a few changes should land before merge!

  • ensure cosmos-sdk stays at v0.42.9 at go.mod
  • delete github.com/osmosis-labs/osmosis/v4 directory that has been newly made, these seem to have been created when generated proto without setting paths in the proto gen script file.

@faddat
Copy link
Member Author

faddat commented Jan 27, 2022

thanks! I thought I'd gotten that v4 folder out. brb :)

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should be good to merge! Thanks @faddat !

@ValarDragon ValarDragon merged commit c50909b into osmosis-labs:v4.x Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants