-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic versioning for osmosis v4.x #780
Semantic versioning for osmosis v4.x #780
Conversation
github.com/marwan-at-work/mod
… updated the go module paths in the .proto files
Codecov Report
@@ Coverage Diff @@
## v4.x #780 +/- ##
=======================================
Coverage ? 20.07%
=======================================
Files ? 164
Lines ? 23253
Branches ? 0
=======================================
Hits ? 4667
Misses ? 17830
Partials ? 756 Continue to review full report at Codecov.
|
I'll fix up the linting tomorrow :) |
} | ||
|
||
|
||
option go_package = "github.com/osmosis-labs/osmosis/x/gamm/types"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this part is missed for the sem ver!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you replace line27 of scripts/generate-proto.sh
with
cp -r ./github.com/osmosis-labs/osmosis/v*/x/* x/
I noticed that proto files were being generated in a separate directory, changing the script file with the line above should do the trick!
If your busy with other stuff going on, I can also this PR over!
Hi Matt, we spoke last night and I said this was ready to go 😝 -- what I did not realize was that it is ready to go only: .... in goland .... on my computer (but not here) I'll push now |
…smosis into faddat/semverfix
Another thing that I did is make this version:
|
LGTM once lint issues are fixed! (I believe just commenting out errcheck right?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just a few changes should land before merge!
- ensure cosmos-sdk stays at v0.42.9 at go.mod
- delete github.com/osmosis-labs/osmosis/v4 directory that has been newly made, these seem to have been created when generated proto without setting paths in the proto gen script file.
thanks! I thought I'd gotten that v4 folder out. brb :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Should be good to merge! Thanks @faddat !
Closes: #621
Description
I found an import of app.go that wasn't changed to v4, and changed that.
Also, I changed some import paths in the .proto files and then ran make proto-all.
For contributor use:
docs/
) or specification (x/<module>/spec/
)Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer