Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat x/bridge: updated TSS.md #7898

Merged
merged 1 commit into from
Apr 2, 2024
Merged

feat x/bridge: updated TSS.md #7898

merged 1 commit into from
Apr 2, 2024

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Apr 1, 2024

Epic: #7643

What is the purpose of the change

TSS library selection.

Testing and Verifying

This change is a documentation addition.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

Summary by CodeRabbit

  • Documentation
    • Updated the TSS documentation with new and existing project entries.
    • Enhanced project descriptions and clarified the absence of built-in transport in a specific project.
    • Raised concerns regarding the code quality in a project due to legacy dependencies.

@keruch keruch self-assigned this Apr 1, 2024
Copy link
Contributor

coderabbitai bot commented Apr 1, 2024

Warning

Rate Limit Exceeded

@keruch has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 6 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 2068bbb and 4d598b5.

Walkthrough

The recent updates bring a fresh entry for entropyxyz/synedrion marked as TODO, alongside significant enhancements and clarifications to existing projects such as coinbase/kryptology and SwingbyProtocol/tss-lib. Notably, these changes include updates on project specifics, a pointed out absence of built-in transport in one, and concerns over code quality in another due to old dependencies.

Changes

Files Summaries
x/bridge/TSS.md - New entry for entropyxyz/synedrion (TODO)
- Updated information about coinbase/kryptology and SwingbyProtocol/tss-lib
- Clarified the lack of built-in transport in a project and provided references for further details
- Mentioned doubts on the quality of code in a specific project due to legacy dependencies

🐇✨

In the code forest, under the moon's glow,
A rabbit hopped, with updates in tow.
"New entries and fixes, oh what a sight,
Transport missing, and code not quite right."
With a hop and a skip, the changes were sown,
In the GitHub garden, where knowledge has grown.
🌟📚🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Apr 1, 2024
@keruch keruch added V:state/compatible/backport State machine compatible PR, should be backported A:no-changelog A:backport/v24.x backport patches to v24.x branch and removed C:docs Improvements or additions to documentation labels Apr 1, 2024
@keruch keruch force-pushed the kirill/bridge-tss-libs branch from 169ece4 to b6c8c61 Compare April 1, 2024 08:22
@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Apr 1, 2024
@keruch keruch force-pushed the kirill/bridge-tss-libs branch 2 times, most recently from 88b2ddc to c5b82c7 Compare April 1, 2024 08:29
@keruch keruch force-pushed the kirill/bridge-tss-libs branch from c5b82c7 to 4d598b5 Compare April 1, 2024 08:47
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thank you!

@czarcas7ic czarcas7ic merged commit 32a5797 into main Apr 2, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the kirill/bridge-tss-libs branch April 2, 2024 00:35
mergify bot pushed a commit that referenced this pull request Apr 2, 2024
czarcas7ic pushed a commit that referenced this pull request Apr 2, 2024
(cherry picked from commit 32a5797)

Co-authored-by: keruch <53012408+keruch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v24.x backport patches to v24.x branch A:no-changelog C:docs Improvements or additions to documentation V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants