Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.x matinenance #790

Closed
wants to merge 5 commits into from
Closed

v3.x matinenance #790

wants to merge 5 commits into from

Conversation

faddat
Copy link
Member

@faddat faddat commented Jan 27, 2022

Works towards: #788

Description

This PR fixes some issues with osmosis importing v1.0 series code into its v3 self.

It also:

  • bumps to tendermint v0.34.15
  • bumps to tm-db v0.6.6
  • adds support for gorocksdb via cosmos/gorocksdb

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v3.x@f86c90f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v3.x     #790   +/-   ##
=======================================
  Coverage        ?   18.23%           
=======================================
  Files           ?      137           
  Lines           ?    21848           
  Branches        ?        0           
=======================================
  Hits            ?     3985           
  Misses          ?    17201           
  Partials        ?      662           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f86c90f...51f5467. Read the comment docs.

@faddat faddat mentioned this pull request Jan 27, 2022
5 tasks
@faddat faddat changed the title Makes v3.x support gorocksdb so that users can make an archive node q… v3.x matinenance Jan 29, 2022
@mattverse
Copy link
Member

Thanks for this!
Just out of curiosity, is this PR unfinished or draft, or is there a particular reason why certain imports do not have updated sem-ver?

@faddat
Copy link
Member Author

faddat commented Feb 4, 2022

Sorry, that's a bug

definitely thought it was finished.

@faddat
Copy link
Member Author

faddat commented Feb 16, 2022

closing this to make from a branch here

@faddat faddat closed this Feb 16, 2022
@mattverse
Copy link
Member

@faddat Oh was this waiting on me for review or was in WIP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants