-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic versioning for v7 #804
Conversation
…into annotation
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to merge once go.mod sdk version is reverted to original state!
I am generally lost as to what is standard for golang projects. Is it to make main with breaking changes with one version higher, or is it with the same last major release. Also how do golang projects do backports with these version import differences :/ |
From my knowledge its make breaking changes with one version higher. |
|
You know, there's an issue in this, too. I'm going to jump off of main a second time, to avoid it. |
@ValarDragon if you still want to use mergify, we need to add it to this repo. I am going to close this one because I think it might add commits of Sunny's not meant for Also seems like some of the wasm tests are trying to import /x/ibc I think I got halfway through an upgrade of the tests w/ Juno and it should be the same kind of thing so I'll try and fix them. It turned out to be quite easy to resolve and was not related to the wasm code 🍾 |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
- Coverage 20.30% 20.21% -0.10%
==========================================
Files 191 192 +1
Lines 24740 24854 +114
==========================================
Hits 5023 5023
- Misses 18793 18907 +114
Partials 924 924 ☔ View full report in Codecov by Sentry. |
@mattverse this is complete and I've merged the latest main branch now, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this @faddat
In the future, we don't want main to have sem-ver of the next major release, but sem-ver for the latest release, since that would make sense for all the backporting that would be happening. Since we have a major upgrade coming up soon, this PR, in particular, makes sense + super helpful!
@@ -0,0 +1,220 @@ | |||
package keeper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets re-delete this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the in-depth review @mattverse / checking what other projects do as the standard here.
Did a quick skim, and only saw the v7 change + the re-added legacy.go file.
Lets also file an issue to add the semver situation to the contributing.md
Going to go ahead and merge before this is broken by the next PR |
Works on: #788
Description
Semantic versioning for osmosis v7
For contributor use:
docs/
) or specification (x/<module>/spec/
)Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer