Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IBC-rate limits descendant recheck calls #8420

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Remove IBC-rate limits descendant recheck calls #8420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f121350
Remove IBC-rate limits descendant recheck calls
ValarDragon Jun 20, 2024
9f55873
Add Changelog
ValarDragon Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### State Compatible

* [#8420](https://github.com/osmosis-labs/osmosis/pull/8420) Remove further unneeded IBC acknowledgements time from CheckTx/RecheckTx.

## v25.1.2

* [#8415](https://github.com/osmosis-labs/osmosis/pull/8415) Reset cache on pool creation
Expand Down
3 changes: 2 additions & 1 deletion x/ibc-rate-limit/ibc_module.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ func (im *IBCModule) OnAcknowledgementPacket(
relayer sdk.AccAddress,
) error {
if ctx.IsCheckTx() || ctx.IsReCheckTx() {
return im.app.OnAcknowledgementPacket(ctx, packet, acknowledgement, relayer)
return nil
// return im.app.OnAcknowledgementPacket(ctx, packet, acknowledgement, relayer)
Comment on lines +165 to +166
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change in transaction handling logic in OnAcknowledgementPacket.

The modification to return nil during IsCheckTx or IsReCheckTx contexts changes the flow significantly. While this may be intended for performance optimization, it's crucial to ensure it doesn't bypass necessary checks or state updates that should occur even in these contexts. Please confirm if all implications of this change have been thoroughly tested.

}
var ack channeltypes.Acknowledgement
if err := json.Unmarshal(acknowledgement, &ack); err != nil {
Expand Down