Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to use distroless base image #869

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Update Dockerfile to use distroless base image #869

merged 3 commits into from
Feb 15, 2022

Conversation

niccoloraspa
Copy link
Member

@niccoloraspa niccoloraspa commented Feb 15, 2022

Addresses #816

Description

This PR introduces a new Dockerfile to build and distribute the osmosisd binary.
The Dockerfile uses multistage build process and serves osmosisd inside a distroless base container image.

To test the Dockerfile against the latest tag (but any commit will do):

git clone https://github.com/osmosis-labs/osmosis
cd osmosis
git checkout v6.3.0
# Replace Dockerfile with the one above
docker build -t osmosis:v6.3.0 .

Then you can run the container as you normally would do with the binary:

docker run osmosis:v6.3.0 version 
# 6.3.0

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@czarcas7ic
Copy link
Member

We should link at some point to document interacting with osmosisd via docker (i.e best way to automate getting required files for the home dir, basic docker commands, etc). This is great though, much needed!

@daniel-farina
Copy link
Contributor

I had the same though as @czarcas7ic . I created an issue to track this:
osmosis-labs/docs#21

Everything else looks good, ready to merge @ValarDragon

@ValarDragon ValarDragon merged commit 7343206 into osmosis-labs:main Feb 15, 2022
@ValarDragon ValarDragon mentioned this pull request Feb 17, 2022
@niccoloraspa niccoloraspa deleted the feat/improve-dockerfile branch March 16, 2022 10:24
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants