Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to osmoutils for having a function write to state if no err #872

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

ValarDragon
Copy link
Member

@antstalepresh made a neat method for doing this in a few places in the
superfluid epoch logic. This just refactors it to a standalone method in
osmoutils.

Furthermore, this PR also renames osmotestutils -> osmoutils, which
is a change I've wanted to make for a while.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@antstalepresh made a neat method for doing this in a few places in the
superfluid epoch logic. This just refactors it to a standalone method in
osmoutils.

Furthermore, this PR also renames osmotestutils -> osmoutils, which
is a change I've wanted to make for a while.
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #872 (0e268a8) into main (9b977f3) will increase coverage by 0.41%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
+ Coverage   19.89%   20.30%   +0.41%     
==========================================
  Files         191      191              
  Lines       24777    24772       -5     
==========================================
+ Hits         4929     5031     +102     
+ Misses      18984    18818     -166     
- Partials      864      923      +59     
Impacted Files Coverage Δ
x/pool-incentives/client/cli/tx.go 0.00% <0.00%> (ø)
x/superfluid/keeper/distribution.go 85.71% <100.00%> (+12.03%) ⬆️
x/gamm/pool-models/balancer/balancerPool.pb.go 14.73% <0.00%> (+14.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b977f3...0e268a8. Read the comment docs.

Copy link
Member

@UnityChaos UnityChaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ValarDragon ValarDragon merged commit e7ab669 into main Feb 15, 2022
@ValarDragon ValarDragon deleted the dev/cache_ctx branch February 15, 2022 22:27
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants