-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump cometbft version #8807
build: bump cometbft version #8807
Conversation
Important Notice This PR modifies an in-repo Go module. It is one of:
The dependent Go modules, especially the root one, will have to be Please follow the instructions below:
Please let us know if you need any help. |
WalkthroughThe pull request updates the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
CHANGELOG.md (2)
54-54
: Consider adding more context to the changelog entry.The changelog entry could be more descriptive by specifying:
- The version being upgraded to (v0.38.15-v27-osmo-1)
- Brief mention of key changes/fixes included in the upgrade
-* [#8807](https://github.com/osmosis-labs/osmosis/pull/8807) chore: bump cometbft version +* [#8807](https://github.com/osmosis-labs/osmosis/pull/8807) chore: bump cometbft version to v0.38.15-v27-osmo-1 for performance improvements and bug fixes
Line range hint
1-1000
: Consider standardizing changelog entry formatting.The changelog would benefit from consistent formatting across all entries:
- End punctuation: Standardize whether entries end with periods
- Capitalization: Use consistent capitalization for entry descriptions
- PR links: Ensure all entries have PR links where applicable
Example standardization:
-* fix: supply offsets for osmo token +* [#8751](https://github.com/osmosis-labs/osmosis/pull/8751) Fix: Supply offsets for OSMO token.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (6)
go.mod
is excluded by!**/*.mod
go.sum
is excluded by!**/*.sum
,!**/*.sum
go.work
is excluded by!**/*.work
,!**/*.work
osmoutils/go.mod
is excluded by!**/*.mod
x/epochs/go.mod
is excluded by!**/*.mod
x/ibc-hooks/go.mod
is excluded by!**/*.mod
📒 Files selected for processing (1)
CHANGELOG.md
(1 hunks)
* build: bump cometbft version * chore: changelog * chore: match go.work to go.mod (cherry picked from commit cdb546d)
What is the purpose of the change
Bumping cometbft to the lastest version:
comet => https://github.com/osmosis-labs/cometbft/releases/tag/v0.38.15-v27-osmo-1