Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump cometbft version #8807

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

crnbarr93
Copy link
Contributor

What is the purpose of the change

Bumping cometbft to the lastest version:

comet => https://github.com/osmosis-labs/cometbft/releases/tag/v0.38.15-v27-osmo-1

@crnbarr93 crnbarr93 added V:state/breaking State machine breaking PR A:backport/v27.x backport patches to v27.x branch labels Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

Copy link
Contributor

coderabbitai bot commented Nov 8, 2024

Walkthrough

The pull request updates the CHANGELOG.md file to document several modifications under the "Unreleased" section. Key changes include the bump of the cometbft version, fixes for state exports related to the governance module, and adjustments for OSMO token supply offsets. Additionally, it includes new entries for missing proto files for indexing and enhancements to the x/gauges module, indicating improvements in state management and configuration.

Changes

File Change Summary
CHANGELOG.md - Added entry for cometbft version bump (#8807)
- Added entry for state export fix for governance module (#8777)
- Added entry for supply offsets fix for OSMO token (#8751)
- Added entry for missing proto files for indexing (#8754)
- Added entry for fixing multiple temporary directories on command executions (#8726)
- Added entry for additional queries in x/gauges module (#8563)

Possibly related PRs

Suggested reviewers

  • mattverse
  • nicolaslara
  • PaddyMc
  • czarcas7ic

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
CHANGELOG.md (2)

54-54: Consider adding more context to the changelog entry.

The changelog entry could be more descriptive by specifying:

  • The version being upgraded to (v0.38.15-v27-osmo-1)
  • Brief mention of key changes/fixes included in the upgrade
-* [#8807](https://github.com/osmosis-labs/osmosis/pull/8807) chore: bump cometbft version
+* [#8807](https://github.com/osmosis-labs/osmosis/pull/8807) chore: bump cometbft version to v0.38.15-v27-osmo-1 for performance improvements and bug fixes

Line range hint 1-1000: Consider standardizing changelog entry formatting.

The changelog would benefit from consistent formatting across all entries:

  1. End punctuation: Standardize whether entries end with periods
  2. Capitalization: Use consistent capitalization for entry descriptions
  3. PR links: Ensure all entries have PR links where applicable

Example standardization:

-* fix: supply offsets for osmo token
+* [#8751](https://github.com/osmosis-labs/osmosis/pull/8751) Fix: Supply offsets for OSMO token.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9e46748 and 6f7b26d.

⛔ Files ignored due to path filters (6)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum, !**/*.sum
  • go.work is excluded by !**/*.work, !**/*.work
  • osmoutils/go.mod is excluded by !**/*.mod
  • x/epochs/go.mod is excluded by !**/*.mod
  • x/ibc-hooks/go.mod is excluded by !**/*.mod
📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)

@crnbarr93 crnbarr93 merged commit cdb546d into main Nov 8, 2024
1 check passed
@crnbarr93 crnbarr93 deleted the chore/bump-osmosis-cosmos-sdk-and-comet-to-latest branch November 8, 2024 09:38
mergify bot pushed a commit that referenced this pull request Nov 8, 2024
* build: bump cometbft version

* chore: changelog

* chore: match go.work to go.mod

(cherry picked from commit cdb546d)
PaddyMc pushed a commit that referenced this pull request Nov 8, 2024
* build: bump cometbft version

* chore: changelog

* chore: match go.work to go.mod

(cherry picked from commit cdb546d)

Co-authored-by: Connor Barr <crnbarr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v27.x backport patches to v27.x branch C:x/epochs V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants