Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address wasmd PR comments #950

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Address wasmd PR comments #950

merged 2 commits into from
Feb 22, 2022

Conversation

ethanfrey
Copy link
Contributor

Description

Thank you @alpe

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

ValarDragon
ValarDragon approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @ethanfrey @alpe!

Will try to learn more about whats going on here after superfluid testnet is up

@ValarDragon ValarDragon merged commit ded135b into main Feb 22, 2022
@ValarDragon ValarDragon deleted the wasmd-pr-comments branch February 22, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanfrey @ValarDragon