Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message server init #966

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Fix message server init #966

merged 2 commits into from
Feb 24, 2022

Conversation

ValarDragon
Copy link
Member

Closes: #XXX

Description

@mattverse


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #966 (b85bee0) into main (1228659) will increase coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
+ Coverage   20.61%   20.76%   +0.14%     
==========================================
  Files         193      193              
  Lines       25087    25254     +167     
==========================================
+ Hits         5172     5243      +71     
- Misses      18964    19056      +92     
- Partials      951      955       +4     
Impacted Files Coverage Δ
x/lockup/handler.go 0.00% <0.00%> (ø)
x/lockup/keeper/msg_server.go 24.67% <ø> (ø)
x/superfluid/client/cli/tx.go 0.00% <0.00%> (ø)
x/lockup/keeper/store.go 87.14% <0.00%> (-0.25%) ⬇️
x/superfluid/client/cli/query.go 0.00% <0.00%> (ø)
x/lockup/keeper/utils.go 89.70% <0.00%> (+0.81%) ⬆️
x/superfluid/keeper/grpc_query.go 55.86% <0.00%> (+1.17%) ⬆️
x/lockup/keeper/lock_refs.go 61.36% <0.00%> (+16.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1228659...b85bee0. Read the comment docs.

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this works via cli!

@ValarDragon ValarDragon merged commit db88250 into main Feb 24, 2022
@ValarDragon ValarDragon deleted the dev/fix_msg_server_init branch February 24, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants