Eject and bump max service-worker file size #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the JavaScript bundle is silently ignored by `create-react-app` on build because its pre-gzip file size is over 2mb. To solve this issue we've ejected from `create-react-app` and have bumped up the maximum file size to cache to 4mb. facebook/create-react-app#2612
| // If a URL is already hashed by Webpack, then there is no concern | ||
| // about it being stale, and the cache-busting can be skipped. | ||
| dontCacheBustUrlsMatching: /\.\w{8}\./, | ||
| maximumFileSizeToCacheInBytes: 4 * 1024 * 1024, |
taylorkearns
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the JavaScript bundle is silently ignored by
create-react-appon build because its pre-gzip file size is over 2mb.To solve this issue we've ejected from
create-react-appand havebumped up the maximum file size to cache to 4mb.
facebook/create-react-app#2612