Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regarding dynamic service/action support implementation #24

Open
mnumanuyar opened this issue Oct 8, 2023 · 1 comment
Open

regarding dynamic service/action support implementation #24

mnumanuyar opened this issue Oct 8, 2023 · 1 comment

Comments

@mnumanuyar
Copy link

i am aware there is a cloed issue for it already (#21) but this line hardcodes "msg" part of the function name.

My solution is adding a new parameter to get_type_info func, with a default value of "msg3" to not break anything. However maybe changes to "InterfaceTypeName" makes more sense.

As a side note here says maybe this is repo is not fully maintained.

To sum up my questions:

  • Is this repo maintained? if not, is there a maintained version of this repo?
  • Is supporting actions/services in scope of this repo?
  • Do you have a suggestion regarding solution? Would it be better to change InterfaceTypeName instead of get_type_info?
@mnumanuyar
Copy link
Author

fyi, changeing function def is enough to run something like test_dynmsg/examples/conversion_cpp.cpp. So converting to yaml and back works with just this. but i didnt test it troughly otherwise

And also thanks for fantastic package :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant